Skip to content

Ensure cache configuration has correct number of owners - #41642

Merged
ryanemerson merged 1 commit into
keycloak:mainfrom
pruivo:t_41558
Aug 5, 2025
Merged

ryanemerson merged 1 commit into
keycloak:mainfrom
pruivo:t_41558

Conversation

@pruivo

@pruivo pruivo commented Aug 4, 2025

Copy link
Copy Markdown
Member

Closes #41558

@ryanemerson ryanemerson Aug 5, 2025 •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we agreed that this should be a warning (detailed in the GH issue) so that the user is more aware that their configuration is not being applied as provided.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know, but the other methods that change the number of owners for session caches are logged as INFO, not WARN.
Should I still change this to warn?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. Given that we explicitly changed the behaviour from WARN to INFO in 26.3, it doesn't feel right to change this again. Let's be consistent and use INFO everywhere.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A late comment from my side:

We changed those messages from WARN to INFO as we didn't want to force users to change the XML file when they disabled or enabled persistent sessions.

This might be slightly different as someone is putting (manually) something wrong in the XML file. Still I'm fine with the INFO message here.

Closes keycloak#41558

Signed-off-by: Pedro Ruivo <1492066+pruivo@users.noreply.github.com>
@ryanemerson
ryanemerson merged commit 75afda4 into keycloak:main Aug 5, 2025
@pruivo
pruivo deleted the t_41558 branch August 5, 2025 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ensure cache configuration has correct number of owners

4 participants