Skip to content

enhance: adding the ability to get the root config from a Scope - #41647

Merged
ahus1 merged 1 commit into
keycloak:mainfrom
shawkins:iss36268
Aug 5, 2025
Merged

ahus1 merged 1 commit into
keycloak:mainfrom
shawkins:iss36268

Conversation

@shawkins

@shawkins shawkins commented Aug 4, 2025

Copy link
Copy Markdown
Contributor

closes: #36268

@keycloak-github-bot keycloak-github-bot Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@keycloak-github-bot

Copy link
Copy Markdown

Unreported flaky test detected

If the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.oid4vc.issuance.signing.OID4VCIssuerWellKnownProviderTest#testMetaDataEndpointIsCorrectlySetup

Keycloak CI - Base IT (6)

java.lang.AssertionError: expected:<[RSA-OAEP, RSA-OAEP-256]> but was:<[RSA-OAEP-256, RSA-OAEP]>
	at org.junit.Assert.fail(Assert.java:89)
	at org.junit.Assert.failNotEquals(Assert.java:835)
	at org.junit.Assert.assertEquals(Assert.java:120)
	at org.junit.Assert.assertEquals(Assert.java:146)
...
java.lang.AssertionError: expected:<[RSA-OAEP, RSA-OAEP-256]> but was:<[RSA-OAEP-256, RSA-OAEP]>
	at org.junit.Assert.fail(Assert.java:89)
	at org.junit.Assert.failNotEquals(Assert.java:835)
	at org.junit.Assert.assertEquals(Assert.java:120)
	at org.junit.Assert.assertEquals(Assert.java:146)
...

Report flaky test

@shawkins
shawkins marked this pull request as ready for review August 4, 2025 19:35
@shawkins
shawkins requested review from a team as code owners August 4, 2025 19:35
@shawkins
shawkins force-pushed the iss36268 branch 2 times, most recently from 2d5954b to 05509d1 Compare August 4, 2025 21:06
@shawkins
shawkins requested review from mabartos and pruivo August 4, 2025 21:20

@keycloak-github-bot keycloak-github-bot Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@keycloak-github-bot

Copy link
Copy Markdown

Unreported flaky test detected

If the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.oid4vc.issuance.signing.OID4VCIssuerWellKnownProviderTest#testMetaDataEndpointIsCorrectlySetup

Keycloak CI - Base IT (6)

java.lang.AssertionError: expected:<[RSA-OAEP, RSA-OAEP-256]> but was:<[RSA-OAEP-256, RSA-OAEP]>
	at org.junit.Assert.fail(Assert.java:89)
	at org.junit.Assert.failNotEquals(Assert.java:835)
	at org.junit.Assert.assertEquals(Assert.java:120)
	at org.junit.Assert.assertEquals(Assert.java:146)
...

Report flaky test

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpicking, intellij shows the warning Arguments to 'assertEquals()' in wrong order

mabartos
mabartos previously approved these changes Aug 5, 2025

@mabartos mabartos left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shawkins LGTM, thanks!

@shawkins
shawkins force-pushed the iss36268 branch 2 times, most recently from 153a8b9 to 3cbddc6 Compare August 5, 2025 13:17
@shawkins

shawkins commented Aug 5, 2025

Copy link
Copy Markdown
Contributor Author

Updated based upon the reviews.

pruivo
pruivo previously approved these changes Aug 5, 2025
mabartos
mabartos previously approved these changes Aug 5, 2025
closes: keycloak#36268

Signed-off-by: Steve Hawkins <shawkins@redhat.com>
@shawkins
shawkins dismissed stale reviews from mabartos and pruivo via 51760fd August 5, 2025 13:51
@shawkins

shawkins commented Aug 5, 2025

Copy link
Copy Markdown
Contributor Author

One more change - I think we need to not do the camel case and -- compensation logic when dealing with the root. It should be documented as expecting the exact configuration key.

@shawkins
shawkins requested review from mabartos and pruivo August 5, 2025 14:35
@ahus1
ahus1 merged commit 11924e6 into keycloak:main Aug 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Configuration is not available outside of quarkus modules

5 participants