Repository navigation
enhance: adding the ability to get the root config from a Scope - #41647
Merged
Merged
Conversation
Unreported flaky test detectedIf the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR. org.keycloak.testsuite.oid4vc.issuance.signing.OID4VCIssuerWellKnownProviderTest#testMetaDataEndpointIsCorrectlySetup |
shawkins
marked this pull request as ready for review
August 4, 2025 19:35
shawkins
force-pushed
the
iss36268
branch
2 times, most recently
from
August 4, 2025 21:06
2d5954b to
05509d1
Compare
Unreported flaky test detectedIf the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR. org.keycloak.testsuite.oid4vc.issuance.signing.OID4VCIssuerWellKnownProviderTest#testMetaDataEndpointIsCorrectlySetup |
pruivo
reviewed
Aug 5, 2025
Member
There was a problem hiding this comment.
nitpicking, intellij shows the warning Arguments to 'assertEquals()' in wrong order
mabartos
previously approved these changes
Aug 5, 2025
shawkins
force-pushed
the
iss36268
branch
2 times, most recently
from
August 5, 2025 13:17
153a8b9 to
3cbddc6
Compare
Contributor
Author
|
Updated based upon the reviews. |
pruivo
previously approved these changes
Aug 5, 2025
mabartos
previously approved these changes
Aug 5, 2025
closes: keycloak#36268 Signed-off-by: Steve Hawkins <shawkins@redhat.com>
Contributor
Author
|
One more change - I think we need to not do the camel case and -- compensation logic when dealing with the root. It should be documented as expecting the exact configuration key. |
mabartos
approved these changes
Aug 5, 2025
pruivo
approved these changes
Aug 5, 2025
abstractj
approved these changes
Aug 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes: #36268