Repository navigation
Use Optional instead of getOrDefault for settings in testSMTPConnection - #41661
Merged
Merged
Conversation
Closes keycloak#41643 Signed-off-by: rmartinc <rmartinc@redhat.com>
jonkoops
approved these changes
Aug 5, 2025
abstractj
approved these changes
Aug 5, 2025
This was referenced Aug 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #41643
The
getOrDefaultreturnsnullwhennullis explicitly set in the map. And it seems that the console sends"port":nullin the json. So the PR just changes that method for anOptionalfor the parameters received for the test. We cannot test explicitly the defaultnullport because the SMTP server cannot run using privileged 25.