Skip to content

Allow forwarding parameters set as a client note in the authentication session - #41671

Merged
pedroigor merged 1 commit into
keycloak:mainfrom
pedroigor:issue-41670
Aug 6, 2025
Merged

pedroigor merged 1 commit into
keycloak:mainfrom
pedroigor:issue-41670

Conversation

@pedroigor

@pedroigor pedroigor commented Aug 5, 2025 •

Copy link
Copy Markdown
Contributor

Closes #41670
Closes #41459

…n session

Closes keycloak#41670

Signed-off-by: Pedro Igor <pigor.craveiro@gmail.com>

@rmartinc rmartinc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just re-run the tests, yesterday github was unstable in the afternoon.

@keycloak-github-bot keycloak-github-bot Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@keycloak-github-bot

Copy link
Copy Markdown

Unreported flaky test detected

If the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.oid4vc.issuance.signing.OID4VCIssuerWellKnownProviderTest#testMetaDataEndpointIsCorrectlySetup

Keycloak CI - Base IT (6)

java.lang.AssertionError: expected:<[RSA-OAEP, RSA-OAEP-256]> but was:<[RSA-OAEP-256, RSA-OAEP]>
	at org.junit.Assert.fail(Assert.java:89)
	at org.junit.Assert.failNotEquals(Assert.java:835)
	at org.junit.Assert.assertEquals(Assert.java:120)
	at org.junit.Assert.assertEquals(Assert.java:146)
...

Report flaky test

@ahus1 ahus1 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving based on previous reviews.

@pedroigor
pedroigor merged commit 84fc9bb into keycloak:main Aug 6, 2025
@pedroigor
pedroigor deleted the issue-41670 branch August 6, 2025 17:57
@knutz3n knutz3n mentioned this pull request Aug 26, 2025
1 of 2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

4 participants