Skip to content

fix: ensuring the ordering of the providers - #41685

Merged
mabartos merged 1 commit into
keycloak:mainfrom
shawkins:iss41653
Aug 6, 2025
Merged

mabartos merged 1 commit into
keycloak:mainfrom
shawkins:iss41653

Conversation

@shawkins

@shawkins shawkins commented Aug 5, 2025 •

Copy link
Copy Markdown
Contributor

With using the same prioirty for both providers, they were being sorted by a uuid so the order was not stable.

closes: #41653

closes: keycloak#41653

Signed-off-by: Steve Hawkins <shawkins@redhat.com>

@keycloak-github-bot keycloak-github-bot Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@keycloak-github-bot

Copy link
Copy Markdown

Unreported flaky test detected

If the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.webauthn.WebAuthnRegisterAndLoginTest#webAuthnPasswordlessAlternativeWithWebAuthnAndPassword

Keycloak CI - WebAuthn IT (chrome)

java.lang.AssertionError: Expected LogoutConfirmPage but was localhost (https://localhost:8543/auth/realms/test/protocol/openid-connect/logout)
	at org.junit.Assert.fail(Assert.java:89)
	at org.junit.Assert.assertTrue(Assert.java:42)
	at org.keycloak.testsuite.pages.AbstractPage.assertCurrent(AbstractPage.java:38)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
...

Report flaky test

@mabartos mabartos left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shawkins Nice catch, LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Flaky test: org.keycloak.testsuite.oid4vc.issuance.signing.OID4VCIssuerWellKnownProviderTest#testMetaDataEndpointIsCorrectlySetup

2 participants