Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -180,10 +180,10 @@ public static String toDashCase(String key) {

for (int i = 0; i < key.length(); i++) {
char c = key.charAt(i);
if (c == ',') {
c = '-'; // should not happen, but was allowed by the previous logic
}
if (l && Character.isUpperCase(c)) {
if (c == '.') {
c = '-'; // this is not documented, but was in the previous logic
l = false;
} else if (l && Character.isUpperCase(c)) {
sb.append('-');
c = Character.toLowerCase(c);
l = false;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ public String getProvider(String spi) {

@Override
public String getDefaultProvider(String spi) {
return scope(spi).get("provider.default");
return scope(spi).get("provider-default");
}

@Override
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -187,6 +187,20 @@ public void testResolveTransformedValue() {
assertEquals("true", createConfig().getConfigValue("kc.proxy-allow-forwarded-header").getValue());
}

@Test
public void testProviderDefault() {
ConfigArgsConfigSource.setCliArgs("--spi-client-registration--provider-default=openid-connect");
initConfig("client-registration");
assertEquals("openid-connect", Config.getDefaultProvider("client-registration"));
}

@Test
public void testScopePropertyWithPeriod() {
ConfigArgsConfigSource.setCliArgs("--spi-client-registration--openid-connect--some-property=value");
Config.Scope scope = initConfig("client-registration", "openid-connect");
assertEquals("value", scope.get("some.property"));
}

@Test
public void testPropertyNamesFromConfig() {
ConfigArgsConfigSource.setCliArgs("--spi-client-registration-openid-connect-static-jwk-url=http://c.jwk.url");
Expand Down