Repository navigation
Use Optional instead of getOrDefault for settings in testSMTPConnection (26.2) - #41719
Merged
Merged
Conversation
rmartinc
force-pushed
the
backport-41661-26.2
branch
from
August 7, 2025 13:21
11d8512 to
30649cd
Compare
rmartinc
marked this pull request as draft
August 7, 2025 13:34
Contributor
Author
|
It seems that there are issues in the JS CI. If the last node is used 22.18.0 there are errors in the tests (see https://github.com/keycloak/keycloak/actions/runs/16804510625/job/47593956118?pr=41719). Chatting with @jonkoops, commented me to test with the previous version and it seems that is working. So we have to use the previous node version or add all the file extensions in those imports. Finally this issue also affects main, so the JS CI failed because of #41728 |
rmartinc
force-pushed
the
backport-41661-26.2
branch
from
August 7, 2025 14:28
30649cd to
594af71
Compare
rmartinc
marked this pull request as ready for review
August 7, 2025 14:30
Closes keycloak#41643 Signed-off-by: rmartinc <rmartinc@redhat.com> (cherry picked from commit a58556d)
rmartinc
force-pushed
the
backport-41661-26.2
branch
from
August 8, 2025 12:45
594af71 to
b41f579
Compare
Contributor
Author
|
Rebase to incorporate the fix for node fix. |
ahus1
approved these changes
Aug 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #41643
PR: #41661
Commit: a58556d
PR branch: backport-41661-26.2
Target branch: https://github.com/keycloak/keycloak/tree/release/26.2