Skip to content

Use Optional instead of getOrDefault for settings in testSMTPConnection (26.0) - #41724

Merged
mposolda merged 1 commit into
keycloak:release/26.0from
rmartinc:backport-41661-26.0
Aug 12, 2025
Merged

mposolda merged 1 commit into
keycloak:release/26.0from
rmartinc:backport-41661-26.0

Conversation

@rmartinc

@rmartinc rmartinc commented Aug 7, 2025

Copy link
Copy Markdown
Contributor

Closes #41643

PR: #41661
Commit: a58556d
PR branch: backport-41661-26.0
Target branch: https://github.com/keycloak/keycloak/tree/release/26.0

Closes keycloak#41643

Signed-off-by: rmartinc <rmartinc@redhat.com>
(cherry picked from commit a58556d)
@rmartinc
rmartinc requested a review from a team as a code owner August 7, 2025 13:32

@keycloak-github-bot keycloak-github-bot Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@keycloak-github-bot

Copy link
Copy Markdown

Unreported flaky test detected

If the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.broker.KcOidcBrokerTest#testPostBrokerLoginFlowWithOTP_bruteForceEnabled

Keycloak CI - Java Distribution IT (windows-latest - temurin - 17)

java.lang.AssertionError: User should be disabled by brute force.
	at org.junit.Assert.fail(Assert.java:89)
	at org.junit.Assert.assertTrue(Assert.java:42)
	at org.keycloak.testsuite.broker.AbstractAdvancedBrokerTest.testPostBrokerLoginFlowWithOTP_bruteForceEnabled(AbstractAdvancedBrokerTest.java:580)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
...

Report flaky test

@mposolda mposolda self-assigned this Aug 12, 2025
@mposolda
mposolda merged commit dad939b into keycloak:release/26.0 Aug 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants