Skip to content

Added PushTheButtonPage for AuthenticatorSubflowsTest2 - #48431

Merged
ahus1 merged 1 commit into
keycloak:mainfrom
msdaly200:47477
Apr 24, 2026
Merged

ahus1 merged 1 commit into
keycloak:mainfrom
msdaly200:47477

Conversation

@msdaly200

@msdaly200 msdaly200 commented Apr 23, 2026 •

Copy link
Copy Markdown
Contributor

Closes #47477

Flaky test is caused by AppPage not being fully loaded, before check kicks in - added PushTheButtonPage which will wait for the page to load.

@keycloak-github-bot keycloak-github-bot Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@keycloak-github-bot

Copy link
Copy Markdown

Unreported flaky test detected

If the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.authz.PolicyEvaluationTest#

Keycloak CI - Base IT (3)

org.opentest4j.AssertionFailedError: expected: <PERMIT> but was: <null>
	at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
	at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)
	at org.junit.jupiter.api.AssertEquals.failNotEqual(AssertEquals.java:197)
	at org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:182)
...
org.opentest4j.AssertionFailedError: expected: <PERMIT> but was: <null>
	at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
	at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)
	at org.junit.jupiter.api.AssertEquals.failNotEqual(AssertEquals.java:197)
	at org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:182)
...
org.opentest4j.AssertionFailedError: expected: <PERMIT> but was: <null>
	at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
	at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)
	at org.junit.jupiter.api.AssertEquals.failNotEqual(AssertEquals.java:197)
	at org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:182)
...

Report flaky test

Signed-off-by: Marie Daly <marie.daly1@ibm.com>
@msdaly200 msdaly200 changed the title Added PushTheButtonPage Added PushTheButtonPage for AuthenticatorSubflowsTest2 Apr 24, 2026

@rmartinc rmartinc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@msdaly200 confirmed that she has tested this several times in the GHA. Thanks!

@ahus1
ahus1 merged commit a79ade6 into keycloak:main Apr 24, 2026
85 checks passed
@msdaly200
msdaly200 deleted the 47477 branch April 30, 2026 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Flaky test: org.keycloak.testsuite.forms.AuthenticatorSubflowsTest2#testSubflow2

3 participants