Repository navigation
Update react router dependency - #51764
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates React Router from v6 to v7 across both UI applications.
Changes:
- Upgrades
react-router-domto 7.18.2. - Refreshes transitive dependencies in the PNPM lockfile.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
js/apps/admin-ui/package.json |
Updates the Admin UI dependency. |
js/apps/account-ui/package.json |
Updates the Account UI dependency. |
js/pnpm-lock.yaml |
Locks React Router 7 and its transitive dependencies. |
Files not reviewed (1)
- js/pnpm-lock.yaml: Generated file
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| @@ -38,7 +38,7 @@ | |||
| "react-dom": "^18.3.1", | |||
| "react-hook-form": "^7.70.0", | |||
| "react-i18next": "^16.5.1", | |||
| "react-router-dom": "^6.30.4" | |||
| "react-router-dom": "^7.18.2" | |||
Contributor
|
We could merge PR #51160 first that would make migration easier |
Contributor
|
We can't move to react router 8 as we don't have react 19, that is only supported by patternfly 6 |
Contributor
Author
Is that something you would want to backport to 26.4, 26.6, and 26.7? If not that we should probably do this as a separate thing first, and backport it, then do that change after? In either case I asked Claude to fix the issues with this PR, seems to make sense to me, but I'm not a JS expert for sure ;) |
stianst
force-pushed
the
dep-update-react-router
branch
from
August 18, 2026 07:21
421097e to
3a2ca3e
Compare
edewit
previously approved these changes
Aug 18, 2026
stianst
force-pushed
the
dep-update-react-router
branch
from
August 19, 2026 07:03
3a2ca3e to
987bd61
Compare
stianst
force-pushed
the
dep-update-react-router
branch
from
August 20, 2026 07:36
987bd61 to
4791f03
Compare
edewit
previously approved these changes
Aug 20, 2026
Unreported flaky test detectedIf the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR. org.keycloak.testsuite.federation.ldap.LDAPGroupMapperTest#test06_addingUserToNewKeycloakGrouporg.keycloak.testsuite.webauthn.registration.WebAuthnOtherSettingsTest#timeout |
Signed-off-by: Erik Jan de Wit <erikjan.dewit@gmail.com>
edewit
previously approved these changes
Aug 27, 2026
Signed-off-by: Erik Jan de Wit <erikjan.dewit@gmail.com>
edewit
approved these changes
Aug 27, 2026
This was referenced Aug 27, 2026
stianst
added a commit
that referenced
this pull request
Aug 28, 2026
* Update react router dependency * Fixes * Fix * remove runtime route-generation crashes after React Router v7 * test stabilization --------- (cherry picked from commit 0ed4f12) Signed-off-by: stianst <stianst@gmail.com> Signed-off-by: Erik Jan de Wit <erikjan.dewit@gmail.com> Co-authored-by: Stian Thorgersen <stianst@gmail.com>
stianst
added a commit
that referenced
this pull request
Sep 1, 2026
* Update react router dependency (#51764) * Update react router dependency Signed-off-by: stianst <stianst@gmail.com> * Fixes Signed-off-by: stianst <stianst@gmail.com> * Fix Signed-off-by: stianst <stianst@gmail.com> * remove runtime route-generation crashes after React Router v7 Signed-off-by: Erik Jan de Wit <erikjan.dewit@gmail.com> * test stabilization Signed-off-by: Erik Jan de Wit <erikjan.dewit@gmail.com> --------- Signed-off-by: stianst <stianst@gmail.com> Signed-off-by: Erik Jan de Wit <erikjan.dewit@gmail.com> Co-authored-by: Erik Jan de Wit <erikjan.dewit@gmail.com> (cherry picked from commit 0ed4f12) * lockfile fix Signed-off-by: Erik Jan de Wit <erikjan.dewit@gmail.com> * merge error fix Signed-off-by: Erik Jan de Wit <erikjan.dewit@gmail.com> * cherry picked test stabilization Signed-off-by: Erik Jan de Wit <erikjan.dewit@gmail.com> --------- Signed-off-by: stianst <stianst@gmail.com> Signed-off-by: Erik Jan de Wit <erikjan.dewit@gmail.com> Co-authored-by: Stian Thorgersen <stianst@gmail.com>
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
6.x is no longer supported; https://github.com/remix-run/react-router?tab=security-ov-file. Not sure if we should upgrade to 7.x or 8.x. Just trying with 7.x to see if it passes CI for now
Closes #51878
Signed-off-by: stianst stianst@gmail.com