Skip to content

Follow-up to #52391: fix stale provider client lookup in KcSamlSignedDocumentOnlyBrokerTest #52457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pedroigor merged 1 commit into from
Sep 4, 2026
Merged

Follow-up to #52391: fix stale provider client lookup in KcSamlSignedDocumentOnlyBrokerTest #52457

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion ...base/src/test/java/org/keycloak/tests/broker/saml/KcSamlSignedDocumentOnlyBrokerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,10 @@ void configureSignedDocumentOnly() {
String providerSigningCert = activeRs256SigCert(providerRealm);
String consumerSigningCert = activeRs256SigCert(consumerRealm);

String samlClientId = "http://localhost:8080/realms/" + CONSUMER_REALM;
// AbstractKcSamlBrokerTest.configureSamlBrokerEndpoints() (superclass @BeforeEach, runs before
// this one) already renamed the provider client from the seeded placeholder entity id to the
// consumer's actual base URL, so that's the id to look up here, not the placeholder.
String samlClientId = consumerRealm.getBaseUrl();
ClientRepresentation client = providerRealm.admin().clients().findByClientId(samlClientId).get(0);
client.getAttributes().put(SamlConfigAttributes.SAML_ASSERTION_SIGNATURE, "false");
client.getAttributes().put(SamlConfigAttributes.SAML_SERVER_SIGNATURE, "true");
Expand Down
Loading