Repository navigation
Fixing flaky pages assertions in the AbstractAdvancedBrokerTest#loginWithExistingUserWithBruteForceEnabled - #52141
Merged
Conversation
lhanusov
force-pushed
the
51600/kcoidcbrokertest-flaky
branch
from
August 27, 2026 13:23
6e698c2 to
18beb5f
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Replaces flaky title-based waits with stable page-object assertions in the broker brute-force test.
Changes:
- Uses page IDs to verify login and error pages.
- Removes redundant element-enabled waits.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| log.debug(driver.getPageSource()); | ||
| Assertions.fail("Timeout while waiting for login page"); | ||
| } | ||
| loginPage.assertCurrent(); |
…WithExistingUserWithBruteForceEnabled Signed-off-by: Lukas Hanusovsky <lhanusov@redhat.com>
lhanusov
force-pushed
the
51600/kcoidcbrokertest-flaky
branch
from
August 27, 2026 14:10
18beb5f to
dbe2e29
Compare
mposolda
approved these changes
Aug 27, 2026
Unreported flaky test detectedIf the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR. org.keycloak.testsuite.adapter.servlet.SAMLClockSkewAdapterTest#testTokenTimeIsValidKeycloak CI - Adapter IT Strict Cookies |
Unreported flaky test detectedIf the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR. org.keycloak.testsuite.adapter.servlet.SAMLClockSkewAdapterTest#testTokenTimeIsValidKeycloak CI - Adapter IT Strict Cookies |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #51600