Skip to content

Fixing docs CI and links - #53423

Merged
ahus1 merged 3 commits into
keycloak:mainfrom
ahus1:is-53422-fix-docs-ci
Oct 6, 2026
Merged

ahus1 merged 3 commits into
keycloak:mainfrom
ahus1:is-53422-fix-docs-ci

Conversation

@ahus1

@ahus1 ahus1 commented Oct 1, 2026

Copy link
Copy Markdown
Member

Closes #53422

@ahus1

ahus1 commented Oct 1, 2026

Copy link
Copy Markdown
Member Author

@ruchikajha95 - please review when you have the time. Thanks!

@ahus1
ahus1 requested a balanced review from Copilot October 1, 2026 16:44

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

The encrypted PEM release note incorrectly links to the outgoing HTTP guide instead of the TLS guide.

Review effort: Balanced
Findings: 1 Low severity

Open (1)
What changed in this PR

Fixes documentation CI variable detection and replaces broken documentation links.

Changes:

  • Adds a reusable high-availability guide URL.
  • Replaces unsupported link macros with AsciiDoc links.
  • Suppresses a false-positive variable warning for a metrics example.
File Description
document-attributes.adoc Defines the high-availability base URL.
ignored-variables Ignores the metrics-example false positive.
x509.adoc Updates the outgoing HTTP guide link.
26_8_0.adoc Updates high-availability and server guide links.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@ahus1
ahus1 requested a balanced review from Copilot October 1, 2026 16:50

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The focused documentation and CI corrections use valid attributes and target existing guide routes.

Review effort: Balanced
Findings: None

Resolved since last review (1)

@ahus1
ahus1 marked this pull request as ready for review October 1, 2026 20:44
@ahus1
ahus1 requested a review from a team as a code owner October 1, 2026 20:44
@ahus1
ahus1 enabled auto-merge (squash) October 1, 2026 20:44
pedroigor
pedroigor previously approved these changes Oct 2, 2026
@ahus1
ahus1 disabled auto-merge October 2, 2026 10:40
@ahus1
ahus1 marked this pull request as draft October 2, 2026 10:40
ahus1 and others added 2 commits October 2, 2026 12:41
Closes keycloak#53422

Signed-off-by: Alexander Schwartz <alexander.schwartz@ibm.com>
Added support for encrypted PKCS#8 private keys in PEM format for HTTPS configuration and updated management interface options.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Alexander Schwartz <alexander.schwartz@gmx.net>
@ahus1

ahus1 commented Oct 2, 2026

Copy link
Copy Markdown
Member Author

Partly reverted the fix as the rendering problem was fixed in #53458

@ahus1
ahus1 marked this pull request as ready for review October 2, 2026 10:42
Copilot AI balanced review requested due to automatic review settings October 2, 2026 10:42

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The links use defined AsciiDoc attributes and follow existing documentation conventions.

Review effort: Balanced
Findings: None

Signed-off-by: Alexander Schwartz <alexander.schwartz@ibm.com>
@ahus1
ahus1 force-pushed the is-53422-fix-docs-ci branch from 3b0020a to 7d8a97c Compare October 2, 2026 10:44
@ahus1
ahus1 enabled auto-merge (squash) October 5, 2026 14:56

@ruchikajha95 ruchikajha95 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. Thanks @ahus1

@ahus1
ahus1 merged commit 2602700 into keycloak:main Oct 6, 2026
72 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fixing docs references

5 participants