Skip to content

Document admin client organizations.findOne breaking change for 27.0 - #53377

Merged
ahus1 merged 1 commit into
keycloak:mainfrom
ssilvert:issue-53371-upgrade-guide-26.9
Oct 5, 2026
Merged

ahus1 merged 1 commit into
keycloak:mainfrom
ssilvert:issue-53371-upgrade-guide-26.9

Conversation

@ssilvert

@ssilvert ssilvert commented Sep 30, 2026 •

Copy link
Copy Markdown
Contributor

PR #51717 changed organizations.findOne to resolve to undefined for a missing organization instead of rejecting with a 404, but merged without an upgrading-guide entry. Opens the 27.0.0 changes file for it.

Fixes #53371

Assisted-by: Claude Opus 5.5

@ssilvert
ssilvert requested a review from a team as a code owner September 30, 2026 20:26
Copilot AI balanced review requested due to automatic review settings September 30, 2026 20:26

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The documentation accurately reflects the implementation and fulfills the linked issue requirements.

Review effort: Balanced
Findings: None

What changed in this PR

Documents the Keycloak 26.9 admin-client behavior change for missing organizations.

Changes:

  • Adds the 26.9 migration section.
  • Explains the organizations.findOne return behavior and migration path.
File Description
changes.adoc Includes the 26.9 migration guide.
changes-26_9_0.adoc Documents the breaking change and replacement handling.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

pedroigor
pedroigor previously approved these changes Oct 1, 2026
Copilot AI balanced review requested due to automatic review settings October 1, 2026 15:43
@ssilvert
ssilvert force-pushed the issue-53371-upgrade-guide-26.9 branch from ec171c5 to 670f1f0 Compare October 1, 2026 15:43

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The documentation accurately reflects the implementation and provides clear migration guidance.

Review effort: Balanced
Findings: None

@ssilvert

ssilvert commented Oct 1, 2026

Copy link
Copy Markdown
Contributor Author

Need to wait for #53423 to be merged so CI can pass.

@ahus1

ahus1 commented Oct 1, 2026

Copy link
Copy Markdown
Member

@ssilvert - feel free to review and approve #53423 :D

@ahus1 ahus1 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There will be no 26.9 release. The next release is 27.0
Please put these changes to the other file.

@ahus1

ahus1 commented Oct 2, 2026

Copy link
Copy Markdown
Member

CI will now pass as #53458 was resolved.

PR keycloak#51717 changed organizations.findOne to resolve to undefined for a
missing organization instead of rejecting with a 404, but merged without
an upgrading-guide entry. Opens the 27.0.0 changes file for it.

Fixes keycloak#53371

Signed-off-by: Stan Silvert <ssilvert@redhat.com>
Assisted-by: Claude Opus 5.5
@ssilvert
ssilvert force-pushed the issue-53371-upgrade-guide-26.9 branch from 670f1f0 to f1b7477 Compare October 5, 2026 18:43
Copilot AI balanced review requested due to automatic review settings October 5, 2026 18:43
@ssilvert ssilvert changed the title Document admin client organizations.findOne breaking change for 26.9 Document admin client organizations.findOne breaking change for 27.0 Oct 5, 2026
@ssilvert

ssilvert commented Oct 5, 2026

Copy link
Copy Markdown
Contributor Author

@ahus1 - thanks, moved to changes-27_0_0.adoc with a Migrating to 27.0.0 include, and rebased on main to pick up the docs CI fix.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The documentation accurately reflects the implementation and is correctly integrated into the migration guide.

Review effort: Balanced
Findings: None

@ssilvert

ssilvert commented Oct 5, 2026

Copy link
Copy Markdown
Contributor Author

There will be no 26.9 release. The next release is 27.0 Please put these changes to the other file.

@ahus1 PR is ready for re-review.

@ahus1
ahus1 merged commit e846059 into keycloak:main Oct 5, 2026
72 checks passed
@ssilvert
ssilvert deleted the issue-53371-upgrade-guide-26.9 branch October 13, 2026 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Document the admin client organizations.findOne breaking change in the 26.9 upgrading guide

4 participants