Repository navigation
Updating OIDCPublicClientTest to the new test framework - #55029
Draft
PadzerButch wants to merge 4 commits into
Draft
PadzerButch wants to merge 4 commits into
PadzerButch wants to merge 4 commits into
Conversation
Closes keycloak#54602 Signed-off-by: Paddy Buckley <paddy.buckley@ibm.com>
…ng the migrate-test skill Closes keycloak#54986 Signed-off-by: Paddy Buckley <paddy.buckley@ibm.com>
… framework using the migrate-test skill Closes keycloak#55009 Signed-off-by: Paddy Buckley <paddy.buckley@ibm.com>
…rate-test skill Closes keycloak#55017 Signed-off-by: Paddy Buckley <paddy.buckley@ibm.com>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The OIDC test-framework migration has no active review issues.
No open issues 🎉
What changed in this PR
Migrates OIDCPublicClientTest and related OIDC tests to Keycloak’s new test framework, addressing #55017 and extending the migration to scopes, compatibility options, and advanced request parameters.
Changes:
- Replaces Arquillian/JUnit 4 setup with JUnit 5 and injected test resources.
- Adds realm configurations and helpers for scope, consent, and signed/encrypted request tests.
- Removes migrated legacy suites and marks the legacy scope suite for removal.
| File | Description |
|---|---|
testsuite/integration-arquillian/tests/base/src/test/java/org/keycloak/testsuite/oidc/OIDCScopeTest.java |
Marks the legacy scope suite as deprecated for removal. |
testsuite/integration-arquillian/tests/base/src/test/java/org/keycloak/testsuite/oidc/OIDCParameterizedScopeTest.java |
Removes the legacy parameterized-scope suite. |
testsuite/integration-arquillian/tests/base/src/test/java/org/keycloak/testsuite/oidc/OIDCAdvancedRequestParamsTest.java |
Removes the legacy advanced-request suite. |
tests/base/src/test/java/org/keycloak/tests/oidc/OIDCScopeTest.java |
Adds migrated scope, consent, and refresh-token tests. |
tests/base/src/test/java/org/keycloak/tests/oidc/OIDCPublicClientTest.java |
Migrates public-client authentication testing to injected resources. |
tests/base/src/test/java/org/keycloak/tests/oidc/OIDCParameterizedScopeTest.java |
Migrates parameterized-scope tests with feature-enabled server configuration. |
tests/base/src/test/java/org/keycloak/tests/oidc/OIDCBackwardsCompatibilityTest.java |
Migrates response-parameter compatibility tests with per-method realms. |
tests/base/src/test/java/org/keycloak/tests/oidc/OIDCAdvancedRequestParamsTest.java |
Migrates advanced OIDC tests using managed HTTP, key, and realm resources. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #55017