Repository navigation
Code deprecated during cache-embedded-remote-store feature removal - #55221
Draft
ruchikajha95 wants to merge 3 commits into
Draft
ruchikajha95 wants to merge 3 commits into
ruchikajha95 wants to merge 3 commits into
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The PR’s closing reference to #39027 needs correction so merging the cache API cleanup does not close an unrelated user-event metrics release-notes issue.
1 open issue
What changed in this PR
Removes cache APIs deprecated when cache-embedded-remote-store was retired, completing this cleanup for Keycloak 27.
Changes:
- Removes
DCNotifyand deprecated notification overloads, retaining all-datacenter notifications. - Deletes nonlocal authentication-session note updates and their event handling.
- Updates the cache-expiration test and documents migration requirements.
| File | Description |
|---|---|
testsuite/model/src/test/java/org/keycloak/testsuite/model/infinispan/CacheExpirationTest.java |
Uses RealmRemovedSessionEvent for expiration checks. |
server-spi/src/main/java/org/keycloak/sessions/AuthenticationSessionProvider.java |
Removes the deprecated nonlocal auth-note update method. |
server-spi-private/src/main/java/org/keycloak/cluster/ClusterProvider.java |
Removes DCNotify and makes remaining notification methods abstract. |
model/infinispan/src/main/java/org/keycloak/models/sessions/infinispan/remote/RemoteInfinispanAuthenticationSessionProvider.java |
Removes remote auth-note event publishing. |
model/infinispan/src/main/java/org/keycloak/models/sessions/infinispan/InfinispanAuthenticationSessionProviderFactory.java |
Removes auth-note event registration and handling. |
model/infinispan/src/main/java/org/keycloak/models/sessions/infinispan/InfinispanAuthenticationSessionProvider.java |
Removes embedded auth-note event publishing. |
model/infinispan/src/main/java/org/keycloak/models/cache/infinispan/events/AuthenticationSessionAuthNoteUpdateEvent.java |
Deletes the obsolete event class. |
model/infinispan/src/main/java/org/keycloak/marshalling/KeycloakModelSchema.java |
Removes the deleted event from schema registration. |
model/infinispan/src/main/java/org/keycloak/cluster/infinispan/WrapperClusterEvent.java |
Wraps new notifications with all-datacenter semantics. |
model/infinispan/src/main/java/org/keycloak/cluster/infinispan/remote/RemoteInfinispanNotificationManager.java |
Drops the datacenter-selection argument. |
model/infinispan/src/main/java/org/keycloak/cluster/infinispan/remote/RemoteInfinispanClusterProvider.java |
Implements the simplified notification interface. |
model/infinispan/src/main/java/org/keycloak/cluster/infinispan/InfinispanClusterProvider.java |
Simplifies embedded notification dispatch. |
model/infinispan/src/main/java/org/keycloak/cluster/infinispan/DatabaseAwareClusterProvider.java |
Removes datacenter-selection branches from notification persistence. |
docs/documentation/upgrading/topics/changes/changes-27_0_0.adoc |
Documents removed APIs and provider migration requirements. |
Review effort: Balanced
Closes keycloak#39047 Signed-off-by: Ruchika <ruchika.jha1@ibm.com>
Closes keycloak#39047 Signed-off-by: Ruchika <ruchika.jha1@ibm.com>
Closes keycloak#39047 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: Alexander Schwartz <alexander.schwartz@ibm.com>
ahus1
force-pushed
the
iss-39027/cache-embedded-remote-store
branch
from
November 16, 2026 15:19
9b0fea1 to
d275015
Compare
Member
|
@ruchikajha95 - I've removed some other fields that are now unused after your change. Please have a look. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Closes #39047