Skip to content

Code deprecated during cache-embedded-remote-store feature removal - #55221

Draft
ruchikajha95 wants to merge 3 commits into
keycloak:mainfrom
ruchikajha95:iss-39027/cache-embedded-remote-store
Draft

ruchikajha95 wants to merge 3 commits into
keycloak:mainfrom
ruchikajha95:iss-39027/cache-embedded-remote-store

Conversation

@ruchikajha95

@ruchikajha95 ruchikajha95 commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

Closes #39047

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The PR’s closing reference to #39027 needs correction so merging the cache API cleanup does not close an unrelated user-event metrics release-notes issue.

1 open issue
What changed in this PR

Removes cache APIs deprecated when cache-embedded-remote-store was retired, completing this cleanup for Keycloak 27.

Changes:

  • Removes DCNotify and deprecated notification overloads, retaining all-datacenter notifications.
  • Deletes nonlocal authentication-session note updates and their event handling.
  • Updates the cache-expiration test and documents migration requirements.
File Description
testsuite/​model/​src/​test/​java/​org/​keycloak/​testsuite/​model/​infinispan/​CacheExpirationTest.java Uses RealmRemovedSessionEvent for expiration checks.
server-spi/​src/​main/​java/​org/​keycloak/​sessions/​AuthenticationSessionProvider.java Removes the deprecated nonlocal auth-note update method.
server-spi-private/​src/​main/​java/​org/​keycloak/​cluster/​ClusterProvider.java Removes DCNotify and makes remaining notification methods abstract.
model/​infinispan/​src/​main/​java/​org/​keycloak/​models/​sessions/​infinispan/​remote/​RemoteInfinispanAuthenticationSessionProvider.java Removes remote auth-note event publishing.
model/​infinispan/​src/​main/​java/​org/​keycloak/​models/​sessions/​infinispan/​InfinispanAuthenticationSessionProviderFactory.java Removes auth-note event registration and handling.
model/​infinispan/​src/​main/​java/​org/​keycloak/​models/​sessions/​infinispan/​InfinispanAuthenticationSessionProvider.java Removes embedded auth-note event publishing.
model/​infinispan/​src/​main/​java/​org/​keycloak/​models/​cache/​infinispan/​events/​AuthenticationSessionAuthNoteUpdateEvent.java Deletes the obsolete event class.
model/​infinispan/​src/​main/​java/​org/​keycloak/​marshalling/​KeycloakModelSchema.java Removes the deleted event from schema registration.
model/​infinispan/​src/​main/​java/​org/​keycloak/​cluster/​infinispan/​WrapperClusterEvent.java Wraps new notifications with all-datacenter semantics.
model/​infinispan/​src/​main/​java/​org/​keycloak/​cluster/​infinispan/​remote/​RemoteInfinispanNotificationManager.java Drops the datacenter-selection argument.
model/​infinispan/​src/​main/​java/​org/​keycloak/​cluster/​infinispan/​remote/​RemoteInfinispanClusterProvider.java Implements the simplified notification interface.
model/​infinispan/​src/​main/​java/​org/​keycloak/​cluster/​infinispan/​InfinispanClusterProvider.java Simplifies embedded notification dispatch.
model/​infinispan/​src/​main/​java/​org/​keycloak/​cluster/​infinispan/​DatabaseAwareClusterProvider.java Removes datacenter-selection branches from notification persistence.
docs/​documentation/​upgrading/​topics/​changes/​changes-27_0_0.adoc Documents removed APIs and provider migration requirements.

Review effort: Balanced

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues were identified for the deprecated clustering and authentication-session API cleanup.

No open issues 🎉

1 resolved since last review

Review effort: Balanced

ruchikajha95 and others added 3 commits November 16, 2026 16:15
Closes keycloak#39047

Signed-off-by: Ruchika <ruchika.jha1@ibm.com>
Closes keycloak#39047

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: Alexander Schwartz <alexander.schwartz@ibm.com>
@ahus1
ahus1 force-pushed the iss-39027/cache-embedded-remote-store branch from 9b0fea1 to d275015 Compare November 16, 2026 15:19
@ahus1
ahus1 requested a balanced review from Copilot November 16, 2026 15:19

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues block the deprecated API cleanup and related cluster-event simplification.

No open issues 🎉

Review effort: Balanced

@ahus1

ahus1 commented Nov 16, 2026

Copy link
Copy Markdown
Member

@ruchikajha95 - I've removed some other fields that are now unused after your change. Please have a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove code deprecated during cache-embedded-remote-store feature removal

3 participants