Skip to content

KEYCLOAK-14915 Upgrade registration screen to PF4 - #7546

Merged
mposolda merged 1 commit into
keycloak:masterfrom
mabartos:KEYCLOAK-14915
Nov 18, 2020
Merged

mposolda merged 1 commit into
keycloak:masterfrom
mabartos:KEYCLOAK-14915

Conversation

@mabartos

Copy link
Copy Markdown
Member

JIRA: KEYCLOAK-14915

Old one:
registerOld

New one:
registerNew

@mposolda mposolda left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding one minor comment. Also I am adding @Pepo48 and @vmuzikar as reviewers of this. And it will be good to run UI tests in pipeline with various browsers to doublecheck there is no regression.

@mposolda mposolda self-assigned this Oct 29, 2020
@mposolda
mposolda requested review from Pepo48 and vmuzikar October 29, 2020 12:03
@mabartos

mabartos commented Oct 30, 2020 •

Copy link
Copy Markdown
Member Author

There are some failures in UI tests, but it's not caused by this PR, so these tests were executed successfully for this PR.
https://keycloak-jenkins.com/job/universal-test-pipeline-server/2259/testReport/

@Pepo48

Pepo48 commented Nov 3, 2020

Copy link
Copy Markdown
Contributor

@mabartos first of all - nice job!

The only difference in IE that I see is the missing exclamation mark icon at the right side of the textboxes:
obrázok
But I assume you are already aware of it, don't you? If so, I'm completely fine with it.
Anyway, you may see on the screenshot that the "background overflow" still persists and it is the most visible just on the registration form (obviously because it's the largest form). I think that this is caused by the resolution of the background picture - we could take a look on it as a follow up task.

None of these I perceive as a blocker thus I'm approving it. Thanks!

Pepo48
Pepo48 previously approved these changes Nov 3, 2020

@vmuzikar vmuzikar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found one nitpick. Other than that LGTM. Thank you @mabartos!

@mabartos

mabartos commented Nov 5, 2020

Copy link
Copy Markdown
Member Author

vmuzikar
vmuzikar previously approved these changes Nov 5, 2020

@vmuzikar vmuzikar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @mabartos!

@mabartos

mabartos commented Nov 5, 2020

Copy link
Copy Markdown
Member Author

@vmuzikar @Pepo48 Thanks for approving. I've just squashed the commits.

@mposolda

mposolda commented Nov 5, 2020

Copy link
Copy Markdown
Contributor

@mabartos Approving. Will wait for GH actions to finish.

@mposolda

mposolda commented Nov 6, 2020

Copy link
Copy Markdown
Contributor

@mabartos Looks like lots of test failures and looks like they are regression of this PR. It seems this will require some additional work?

@vmuzikar

vmuzikar commented Nov 6, 2020

Copy link
Copy Markdown
Contributor

@mposolda I think the GH Actions errors are unrelated to this. I saw the exact same failures in my PR: #7586

@vmuzikar

vmuzikar commented Nov 6, 2020

Copy link
Copy Markdown
Contributor

Although it is quite suspicious that all the errors seem to be related to the error notifications which were refactored in this and other PF4 related PRs.

@mposolda

mposolda commented Nov 6, 2020

Copy link
Copy Markdown
Contributor

@vmuzikar Yes, I figured that too and pinged @mabartos about this. It seems to me the GH failures were introduced by 2 previous PRs, which individually were passing, but together there are test failures..

@mabartos

mabartos commented Nov 6, 2020

Copy link
Copy Markdown
Member Author

It seems, there is some issue with cache in GH actions.

@mabartos

Copy link
Copy Markdown
Member Author

For sure, I've started pipeline with this PR and all tests passed. I don't know, why the KC CI is failing. It seems that the themes module is not still built properly.

https://keycloak-jenkins.com/job/universal-test-pipeline-server/2301/

@mposolda
mposolda merged commit ab347df into keycloak:master Nov 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants