Repository navigation
KEYCLOAK-14306 OIDC redirect_uri allows dangerous schemes resulting in potential XSS - #7586
Conversation
|
Since Travis doesn't work, I'm waiting for test results in the test pipeline. |
|
Successful base testsuite run: https://keycloak-jenkins.com/job/universal-test-pipeline-server/2293/ |
|
There's some failures in "Keycloak CI" job: https://github.com/keycloak/keycloak/pull/7586/checks?check_run_id=1359650110 |
@stianst That's weird... It's some Quarkus check, isn't it? I mean, why else would it fail when the test pipeline passed? |
|
I think the test failures are unrelated to this as it apparently affects other PRs too (e.g. #7546). |
|
Now we have a real overlap with #7324. So far, it was only about client validation. We need to figure out how to align the different proposals we have on the table. |
|
@pedroigor So what is your proposal how to handle this in the best way? :) |
|
@vmuzikar I have no clue :) But work later to finally have a single validation approach. |
…n potential XSS (cherry picked from commit e86bec8) Conflicts: testsuite/integration-arquillian/tests/base/src/test/java/org/keycloak/testsuite/client/ClientRegistrationTest.java testsuite/integration-arquillian/tests/base/src/test/java/org/keycloak/testsuite/admin/ClientTest.java services/src/main/java/org/keycloak/validation/DefaultClientValidationProvider.java
d49cd2c to
d886898
Compare
|
I rebased this onto current master but there are still test failures. I was unable to reproduce it locally (all pass for me), so I'm not sure what's happening here. Doesn't GH Actions use some cache or something? |
|
This is a blocker to get merged into master for Keycloak 12, as it is fixing a CVE that is already public and resolved in 11.0.3. So any refactoring is out of scope, and this should get merged assuming it is okay, and passes CI. For sure later we do need to refactor/align on a more consistent approach to validation throughout. |
(cherry picked from commit e86bec8)
Conflicts:
testsuite/integration-arquillian/tests/base/src/test/java/org/keycloak/testsuite/client/ClientRegistrationTest.java
testsuite/integration-arquillian/tests/base/src/test/java/org/keycloak/testsuite/admin/ClientTest.java
services/src/main/java/org/keycloak/validation/DefaultClientValidationProvider.java
All of them are related to #7272.