Repository navigation
KEYCLOAK-2045 Simple Validation SPI for UserProfile SPI - #8053
Conversation
KEYCLOAK-2045 Return ValidationContext with the outcome of the validation in validate methods KEYCLOAK-2045 Move validator lookup from KeycloakSession into dedicated ValidatorLookup class for now KEYCLOAK-2045 Validator SPI polishing KEYCLOAK-2045 Move Validator SPI to server-spi-private for now KEYCLOAK-2045 Add test to demonstrate validator config validation. KEYCLOAK-2045 Add support for context-less validations. KEYCLOAK-2045 Introduce ValidatorConfig and add some default Validator implementations KEYCLOAK-2045 Add license headers KEYCLOAK-2045 Revise BuiltinValidators KEYCLOAK-2045 Validator Polishing KEYCLOAK-2045 Allow lookups for ValidatorFactories for dynamic config validation. KEYCLOAK-2045 Revise ValidatorTests KEYCLOAK-2045 Validator Polishing KEYCLOAK-2045 Add example for nested validation KEYCLOAK-2045 Refactor Validator API KEYCLOAK-2045 Refactor Validator API - Merged BuiltinValidators and ValidatorLookup into Validators facade class KEYCLOAK-2045 Ease validation of ValidatorConfigs KEYCLOAK-2045 Assume ValidatorConfig's are valid for Validator's that don't support config. KEYCLOAK-2045 Make built-in validator method names more for static imports KEYCLOAK-2045 Revise Validation API according to discussions from code review KEYCLOAK-2045 Pass KeycloakSession to ValidatorConfig validation methods. This allows ValidatorConfig validations to access services as well as the current KeycloakContext. KEYCLOAK-2045 Revise Validation API according to discussions from code review - Derive valid state from errors in ValidationContext - Simplify ValidationResult by not inheriting from Consumer<Consmer<ValidationResult>> - Add addtional test cases KEYCLOAK-2045 Revise Validation API according to discussions from code review - Revise NumberValidator to only check for double conversion - Removed support for string based regex pattern KEYCLOAK-2045 Ease validation of ValidatorConfig
|
@velias Could you please check https://github.com/pedroigor/keycloak/tree/KEYCLOAK-17399-validation? |
|
@pedroigor thanks, added few comments to your additional commit. My biggest concern is around format validations over empty strings and how it will work for optional fields in UserProfile (I think registration/update forms produce empty string for them now if not changed in meantime). Do we have final UserProfile functionality merged with this latest version of validators somewhere to test it? |
fdcf698 to
de47dcb
Compare
|
@pedroigor incorporated your changes with some additional changes from me mainly to patch number range validation |
de47dcb to
59c3b21
Compare
|
@thomasdarimont @velias Thanks. |
* KEYCLOAK-2045 Simple Validation API Co-authored-by: Thomas Darimont <thomas.darimont@googlemail.com>
KEYCLOAK-2045 Simple Validation SPI - this PR is follow up of the original PR #7887 by @thomasdarimont. It is refined to work for UserProfile SPI. Main changes against the original PR:
/base/logintheme resourcesKeycloakSession)