Repository navigation
Conversation
This seems to be doing some frame decoding now, but not like... well.
In order to fix this, we needed to preallocate the PCM array before passing it to minimp3, match and initialize the existing C structures and pass buffer.data.as_uchars directly instead of passing a null-terminated string (buffer.data.as_uchars[:]). Turns out I was also not comparing apples to apples with the mp3 and wav comparsion, either.
The package metadata and test configuration still targeted Python 3.6 and 3.7. Update the supported-version classifiers, tox environments and development dependency minimums for Python 3.10+.
Run the test suite on Python 3.10, 3.14 and free-threaded 3.14 under Ubuntu and Windows. Add a separate job for the Black and isort checks.
The implementation is a Cython extension, so describe its Python-facing interface in a stub and mark the package as typed. Re-export that interface from pyminimp3 and check the source tree with pyrefly in tox and CI.
Keep setuptools as the build backend, but move the package metadata, package discovery, typed package data and Cython extension declaration into pyproject.toml. Update the build tox environment to build and check both distributions. Make the source distribution manifest explicit so local virtual environments and scratch files are not swept up by the old recursive Python glob.
Upload coverage data from each test matrix job and combine it into a Markdown workflow summary, with an HTML artifact for more detail. This replaces the old Codecov tox environment without enforcing a minimum coverage percentage.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Turns out this library has been broken all along, but this fixes it. I have been neglecting it so long that it was previously only set up to be tested in Python 3.6 and 3.7 using Travis and with all the build configuration in setup.py, so, I've also gone ahead and done some basic modernization.
Replacing #12 with this because apparently GHA won't trigger a new workflow when the PR is from a branch in a forked repo.