Repository navigation
Expand file tree
/
Copy pathudf_test.rs
More file actions
335 lines (293 loc) · 10.3 KB
/
Copy pathudf_test.rs
File metadata and controls
335 lines (293 loc) · 10.3 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
//! Integration tests for Phase 7.7b — User-Defined Functions (UDFs).
//!
//! Testing conventions: no `{:?}` of Result/Value/Fact in assert messages.
use minigraf::Value;
use minigraf::db::Minigraf;
// ─── helpers ─────────────────────────────────────────────────────────────────
fn db() -> Minigraf {
Minigraf::in_memory().expect("in_memory failed")
}
fn seed(db: &Minigraf, cmds: &[&str]) {
for cmd in cmds {
db.execute(cmd).expect("seed failed");
}
}
// ─── Test 1: custom aggregate (geometric mean) ───────────────────────────────
#[test]
fn custom_aggregate_geometric_mean() {
let db = db();
// geometric mean = exp(mean of ln(values))
db.register_aggregate(
"geomean",
|| (0.0_f64, 0usize), // (sum_of_ln, count)
|acc: &mut (f64, usize), v: &Value| {
if let Value::Float(f) = v {
if *f > 0.0 {
acc.0 += f.ln();
acc.1 += 1;
}
} else if let Value::Integer(i) = v
&& *i > 0
{
acc.0 += (*i as f64).ln();
acc.1 += 1;
}
},
|acc: &(f64, usize), _n: usize| {
if acc.1 == 0 {
Value::Null
} else {
Value::Float((acc.0 / acc.1 as f64).exp())
}
},
)
.expect("register geomean");
seed(
&db,
&[r#"(transact [[:a :item/score 2] [:b :item/score 8]])"#],
);
let result = db
.execute(r#"(query [:find (geomean ?score) :where [?e :item/score ?score]])"#)
.expect("query failed");
if let minigraf::QueryResult::QueryResults { results, .. } = result {
assert_eq!(results.len(), 1);
// geomean(2, 8) = sqrt(16) = 4.0
if let Value::Float(f) = &results[0][0] {
assert!((*f - 4.0).abs() < 1e-9, "expected ~4.0");
} else {
panic!("expected Float result");
}
} else {
panic!("expected QueryResults");
}
}
// ─── Test 2: custom aggregate — empty result returns Null ────────────────────
#[test]
fn custom_aggregate_empty_result() {
let db = db();
db.register_aggregate(
"geomean2",
|| (0.0_f64, 0usize),
|acc: &mut (f64, usize), v: &Value| {
if let Value::Float(f) = v
&& *f > 0.0
{
acc.0 += f.ln();
acc.1 += 1;
}
},
|acc: &(f64, usize), _n: usize| {
if acc.1 == 0 {
Value::Null
} else {
Value::Float((acc.0 / acc.1 as f64).exp())
}
},
)
.expect("register geomean2");
// No facts — empty result
let result = db
.execute(r#"(query [:find (geomean2 ?score) :where [?e :item/score ?score]])"#)
.expect("query failed");
if let minigraf::QueryResult::QueryResults { results, .. } = result {
// Empty input → no groups → no output rows (consistent with built-in behaviour
// for non-count aggregates when no facts match)
assert!(results.is_empty() || results[0][0] == Value::Null);
} else {
panic!("expected QueryResults");
}
}
// ─── Test 3: custom predicate filter ────────────────────────────────────────
#[test]
fn custom_predicate_filter() {
let db = db();
db.register_predicate(
"email?",
|v: &Value| matches!(v, Value::String(s) if s.contains('@')),
)
.expect("register email?");
seed(
&db,
&[r#"(transact [
[:alice :person/email "alice@example.com"]
[:bob :person/email "notanemail"]
])"#],
);
let result = db
.execute(r#"(query [:find ?e :where [?e :person/email ?addr] [(email? ?addr)]])"#)
.expect("query failed");
if let minigraf::QueryResult::QueryResults { results, .. } = result {
assert_eq!(results.len(), 1, "only alice has a valid email");
// Entity IDs are stored as Value::Ref(deterministic UUID derived from the keyword).
// We verify the result is a Ref (entity ID) rather than checking the exact UUID.
assert!(
matches!(results[0][0], Value::Ref(_)),
"entity result must be a Ref"
);
} else {
panic!("expected QueryResults");
}
}
// ─── Test 4: UDF as window function ─────────────────────────────────────────
#[test]
fn udf_as_window_function() {
let db = db();
db.register_aggregate(
"winsum",
|| 0i64,
|acc: &mut i64, v: &Value| {
if let Value::Integer(i) = v {
*acc += i;
}
},
|acc: &i64, _n: usize| Value::Integer(*acc),
)
.expect("register winsum");
seed(
&db,
&[r#"(transact [
[:a :item/score 1]
[:b :item/score 2]
[:c :item/score 3]
])"#],
);
let result = db
.execute(
r#"(query [:find ?e (winsum ?score :over (:order-by ?score))
:where [?e :item/score ?score]])"#,
)
.expect("query failed");
if let minigraf::QueryResult::QueryResults { results, .. } = result {
assert_eq!(results.len(), 3, "three rows");
// After ordering by score: rows are 1,2,3; cumulative sums are 1,3,6
let mut sums: Vec<i64> = results
.iter()
.map(|r| if let Value::Integer(n) = r[1] { n } else { -1 })
.collect();
sums.sort();
assert_eq!(sums, vec![1, 3, 6]);
} else {
panic!("expected QueryResults");
}
}
// ─── Test 5: name collision — shadowing a built-in aggregate ─────────────────
#[test]
fn name_collision_builtin_aggregate() {
let db = db();
let result = db.register_aggregate(
"sum",
|| 0i64,
|_acc: &mut i64, _v: &Value| {},
|acc: &i64, _n: usize| Value::Integer(*acc),
);
assert!(result.is_err(), "shadowing built-in 'sum' must return Err");
}
// ─── Test 6: name collision — UDF-on-UDF ─────────────────────────────────────
#[test]
fn name_collision_udf_on_udf() {
let db = db();
db.register_aggregate(
"myfn",
|| 0i64,
|_acc: &mut i64, _v: &Value| {},
|acc: &i64, _n: usize| Value::Integer(*acc),
)
.expect("first registration");
let result = db.register_aggregate(
"myfn",
|| 0i64,
|_acc: &mut i64, _v: &Value| {},
|acc: &i64, _n: usize| Value::Integer(*acc),
);
assert!(result.is_err(), "duplicate UDF name must return Err");
}
// ─── Test 7: unknown aggregate function → runtime error ──────────────────────
#[test]
fn unknown_function_runtime_error() {
let db = db();
seed(&db, &[r#"(transact [[:a :x 1]])"#]);
let result = db.execute(r#"(query [:find (nosuchfn ?x) :where [?e :x ?x]])"#);
assert!(
result.is_err(),
"unknown aggregate should return Err, not panic"
);
}
// ─── Test 8: unknown predicate → runtime error ───────────────────────────────
#[test]
fn unknown_predicate_runtime_error() {
let db = db();
seed(&db, &[r#"(transact [[:a :x "hello"]])"#]);
let result = db.execute(r#"(query [:find ?e :where [?e :x ?v] [(nosuchpred? ?v)]])"#);
assert!(
result.is_err(),
"unknown predicate should return Err, not panic"
);
}
// ─── Test 9: thread safety ───────────────────────────────────────────────────
#[test]
fn thread_safety() {
use std::sync::Arc;
let db = Arc::new(db());
// Seed some facts.
db.execute(r#"(transact [[:a :x 1] [:b :x 2]])"#)
.expect("seed");
// Spawn reader threads.
let mut handles = Vec::new();
for _ in 0..4 {
let db2 = Arc::clone(&db);
handles.push(std::thread::spawn(move || {
for _ in 0..10 {
db2.execute(r#"(query [:find ?e :where [?e :x _]])"#)
.expect("concurrent read");
}
}));
}
// Register a UDF from the main thread while readers run.
db.register_aggregate(
"threadfn",
|| 0i64,
|acc: &mut i64, v: &Value| {
if let Value::Integer(i) = v {
*acc += i;
}
},
|acc: &i64, _n: usize| Value::Integer(*acc),
)
.expect("register threadfn");
for h in handles {
h.join().expect("reader thread panicked");
}
// Verify the UDF works after concurrent registration.
let result = db
.execute(r#"(query [:find (threadfn ?x) :where [?e :x ?x]])"#)
.expect("post-registration query");
if let minigraf::QueryResult::QueryResults { results, .. } = result {
assert_eq!(results.len(), 1);
assert_eq!(results[0][0], Value::Integer(3)); // 1 + 2
} else {
panic!("expected QueryResults");
}
}
// ─── Test 14: UDF predicate in rule body (issue #83) ─────────────────────────────--
#[test]
fn udf_predicate_works_in_rule_body() {
let db = db();
db.register_predicate("large?", |v| matches!(v, Value::Integer(n) if *n > 100))
.unwrap();
db.execute(r#"(transact [[:e1 :score 200] [:e2 :score 50]])"#)
.unwrap();
db.execute(r#"(rule [(high-scorer ?e) [?e :score ?v] [(large? ?v)]])"#)
.unwrap();
let result = db
.execute(r#"(query [:find ?e :where (high-scorer ?e)])"#)
.unwrap();
if let minigraf::QueryResult::QueryResults { results, .. } = result {
assert_eq!(
results.len(),
1,
"only the entity with score > 100 should match"
);
} else {
panic!("expected QueryResults");
}
}