You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
docs: add ERROR_REFERENCE.md codes for #303/#305 parser trailing-argument errors #352
#303 (merged a2ee4ae, PR #350) and #305 (merged f90ea3e, PR #351) each added new user-facing parser error messages, but neither PR touched docs/ERROR_REFERENCE.md. The reference doc's PRS-0xx taxonomy (added in #192) does not yet cover these paths.
Undocumented error messages
From #303 (src/query/datalog/parser.rs, parse_transact/parse_retract):
"transact takes (transact [facts]) or (transact {opts} [facts]); found N unexpected trailing argument(s) — the valid-time options map must come BEFORE the facts vector, not after"
"retract takes (retract [facts]); found N unexpected trailing argument(s)"
From #305 (src/query/datalog/parser.rs, parse_edn/parse_query/parse_rule):
"unexpected trailing input after a complete form: {token}" (top-level parse_edn)
"query takes (query [...]); found N unexpected trailing argument(s)"
"rule takes (rule [...]); found N unexpected trailing argument(s)"
Work item
Add PRS-0xx entries to docs/ERROR_REFERENCE.md for each of the 5 messages above, following the existing format (cause, resolution steps, bad-input example) used by neighboring PRS-0xx entries. Update the Quick Reference Table at the top of the doc to match.
#277 (structured runtime error codes) explicitly depends on the ERROR_REFERENCE.md taxonomy from #192 and its acceptance criteria require "ERROR_REFERENCE.md codes remain in sync with runtime codes." #277 is deliberately sequenced last in v1.3.0 because it needs the final shape of every other fix's error paths — these two error paths already exist (merged) and are currently undocumented, so this should land before #277 starts assigning runtime codes, not be discovered mid-#277.
Sequencing within v1.3.0
Insert immediately before #277 (last item). No dependency on #302 or #309 — this only requires #303/#305, which are already merged — so it can be worked independently of the #302→#309 pair, but must land before #277.
Depends on: #303 (merged), #305 (merged)
Blocks: #277
Activity