You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
test: three wal_test cases still named and commented as crashes but no longer crash #329
Several tests in tests/wal_test.rs describe themselves as crash simulations but no longer simulate a crash.
Background
When the crash idiom moved from std::mem::forget to real aborting subprocesses, three sites were deliberately converted to a plain drop(db) instead: they were never crash tests. They assert through a live handle throughout, so mem::forget there had been incidental. That judgment was reviewed and is correct.
What did not follow is the naming and the comments.
Specifics
tests/wal_test.rs:341 — "after crash-reopen"
tests/wal_test.rs:376 — "// Crash: skip Drop checkpoint. Nothing is pending though —", which contradicts itself
Misnamed tests are how future readers acquire false beliefs about what is covered. A reader scanning for crash-recovery coverage will count these and be wrong.
Task
Rename wal_recover_rollback_crash to describe what it actually does
Correct the three comments
Check no other test in the file claims a crash it does not perform
Activity
test: fix wal_test cases still named/commented as crashes but no long…