Skip to content

crash-kill.yml on main: run v3's nightly crash-kill rounds with test-oracle (Large variant, #550) #687

Closed

Description

@adityamukho

Summary

#685 (#550 PR 2, merged on v3) added a Large variant to tests/crash_kill_test.rs, under the test-oracle feature: most transactions take the large-transaction path, and a failing large statement rolls back after writing pages. It also changed .github/workflows/crash-kill.yml on v3 to pass --features test-oracle when the branch under test is not main.

Scheduled workflows always run the copy of the file on the default branch (main). So the nightly v3 run (cron 17 15 * * *) still runs without the feature, and the Large variant never runs nightly.

Change

Land v3's .github/workflows/crash-kill.yml on main unchanged, as a separate PR (shared CI changes land on both branches). Its run step:

# v3's large-transaction variant (#550) needs the test hooks.
features=""
if [ "$CRASH_REF" != main ]; then features="--features test-oracle"; fi
cargo test $features --test crash_kill_test -- --nocapture 2>&1 | tee crash-kill-output.txt

main has no test-oracle feature, so its nightly run stays as it is. The failure report's "Reproduce" line also changes ((v3: --features test-oracle)).

Done when

  • The PR to main is merged (squash).
  • The next scheduled v3 run, or a workflow_dispatch with ref: v3, shows the Large variant's rounds (round count 100 per OS, now spread over six variants).

Related: #550, #685, #384.

Metadata

Metadata

Assignees

No one assigned

    Labels

    durabilityData durability concernenhancementNew feature or request

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions