Repository navigation
Merge main into v3: v2.x coverage gates (#523) - #524
Merged
Merged
Conversation
Backport of #522. The gate never checked anything: the instrumented test run failed (lock tests could not find pid_ns_helper), the report was empty, and every module was skipped with a warning. It also parsed `--text` output, which has no per-file percentages. Run the suite with branch coverage on a pinned nightly, fail on a test failure, and check line and branch floors per file from coverage-thresholds.toml (measured on main, less one point) with scripts/coverage_gates.py. Port the v3 tests that apply to v2.x: the WAL fact-size test now reaches the limit, an entry claiming over 1M facts ends replay, a WAL writer in a missing directory fails, and two threads missing one cache page share one copy (that path was reached only by a race, so the gate flapped). Part of #396. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012wXxZguv7PgKQjMMH4yJ5h
Random-input tests reach a few of its branches only in some runs: 78.6% locally, 75.7% in CI. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012wXxZguv7PgKQjMMH4yJ5h
ci(coverage): make the per-file coverage gates real on v2.x (#396)
All conflicts resolved to v3's side: v3 has its own coverage gates, thresholds, tests and docs from #522. src/storage/cache.rs auto-merged a second copy of the concurrent-miss test; kept v3's. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012wXxZguv7PgKQjMMH4yJ5h
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings
main's #523 (the v2.x coverage gates backport) intov3as a merge commit.All conflicts are resolved to v3's side. v3 already has its own coverage gates, thresholds, tests and docs from #522. The conflicted files were
CHANGELOG.md,CLAUDE.md,README.md,ROADMAP.md,coverage-thresholds.toml,docs/TEST_COVERAGE.mdandsrc/wal.rs.src/storage/cache.rsmerged without a conflict but ended up with a second copy of the concurrent-miss test, so I kept v3's version. The resulting tree is identical tov3(791e7b2).🤖 Generated with Claude Code
https://claude.ai/code/session_012wXxZguv7PgKQjMMH4yJ5h