Skip to content

Merge main into v3: v2.x coverage gates (#523) - #524

Merged
adityamukho merged 4 commits into
v3from
merge/main-into-v3-coverage
Oct 10, 2026
Merged

adityamukho merged 4 commits into
v3from
merge/main-into-v3-coverage

Conversation

@adityamukho

Copy link
Copy Markdown
Collaborator

Brings main's #523 (the v2.x coverage gates backport) into v3 as a merge commit.

All conflicts are resolved to v3's side. v3 already has its own coverage gates, thresholds, tests and docs from #522. The conflicted files were CHANGELOG.md, CLAUDE.md, README.md, ROADMAP.md, coverage-thresholds.toml, docs/TEST_COVERAGE.md and src/wal.rs.

src/storage/cache.rs merged without a conflict but ended up with a second copy of the concurrent-miss test, so I kept v3's version. The resulting tree is identical to v3 (791e7b2).

🤖 Generated with Claude Code

https://claude.ai/code/session_012wXxZguv7PgKQjMMH4yJ5h

adityamukho and others added 4 commits October 10, 2026 21:53
Backport of #522. The gate never checked anything: the instrumented
test run failed (lock tests could not find pid_ns_helper), the report
was empty, and every module was skipped with a warning. It also parsed
`--text` output, which has no per-file percentages.

Run the suite with branch coverage on a pinned nightly, fail on a test
failure, and check line and branch floors per file from
coverage-thresholds.toml (measured on main, less one point) with
scripts/coverage_gates.py.

Port the v3 tests that apply to v2.x: the WAL fact-size test now reaches
the limit, an entry claiming over 1M facts ends replay, a WAL writer in a
missing directory fails, and two threads missing one cache page share
one copy (that path was reached only by a race, so the gate flapped).

Part of #396.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_012wXxZguv7PgKQjMMH4yJ5h
Random-input tests reach a few of its branches only in some runs: 78.6%
locally, 75.7% in CI.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_012wXxZguv7PgKQjMMH4yJ5h
ci(coverage): make the per-file coverage gates real on v2.x (#396)
All conflicts resolved to v3's side: v3 has its own coverage gates,
thresholds, tests and docs from #522. src/storage/cache.rs auto-merged a
second copy of the concurrent-miss test; kept v3's.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_012wXxZguv7PgKQjMMH4yJ5h
@codecov

codecov Bot commented Oct 10, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@adityamukho
adityamukho merged commit e69fa66 into v3 Oct 10, 2026
24 checks passed
@adityamukho
adityamukho deleted the merge/main-into-v3-coverage branch October 10, 2026 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant