Repository navigation
test(index): cover lookup_vaet_ref with a fixed unit test - #571
Merged
Merged
Conversation
Only proptest-generated queries reached lookup_vaet_ref, when one happened to plan [?e ?a <entity>] first. On runs where none did, src/storage/index.rs fell to 88% lines against its 92% floor, failing the coverage gate on a corpus-only PR (#563). A unit test now checks that the VAET lookup returns exactly the refs to its target. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0182dkj73849VS8eeGFFHXbW
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
src/storage/index.rsline coverage depended on the proptest seed.lookup_vaet_ref(21 lines) was reached only whentests/property_test.rshappened to generate a query planned with[?e ?a <entity>]first. Main's last run measured 93.89%; the corpus-only PR fuzz: minimized corpus for main #563 measured 88.06% against the 92% floor and failed the coverage gate.test_lookup_vaet_ref_returns_only_refs_to_target: refs from two sources and attributes to one target are both returned, a ref to another target is not, and an unknown target returns nothing.CLAUDE.md,README.md,docs/TEST_COVERAGE.md.v3is not affected (nolookup_vaet_refthere).Test plan
cargo test --lib storage::indexpassesPROPTEST_CASES=1,lookup_vaet_refshowed 0 hits before this change and is covered by the lib tests after itcargo fmt --check,cargo clippy --all-features -- -D warnings🤖 Generated with Claude Code
https://claude.ai/code/session_0182dkj73849VS8eeGFFHXbW