From 116d15b1b87daaf8e71f42a429e4f10ceac44d68 Mon Sep 17 00:00:00 2001 From: Aditya Mukhopadhyay Date: Wed, 14 Oct 2026 10:16:03 +0530 Subject: [PATCH 1/2] docs: issues fixed on unreleased v3 close on merge CONTRIBUTING.md said a fix merged only to v3 does not close its issue. The policy since 2026-10-06 is narrower: only fixes that ship in a patch to a published line (v2.0.x) stay open until that release; fixes on a branch with no release yet close on merge and stay listed in #421 when a published release has the bug. CLAUDE.md and DURABILITY.md follow. Co-Authored-By: Claude Opus 5.5 Claude-Session: https://claude.ai/code/session_01U611mBGbkSqJeSwNz2xd7s --- CLAUDE.md | 2 +- CONTRIBUTING.md | 3 ++- docs/DURABILITY.md | 2 +- 3 files changed, 4 insertions(+), 3 deletions(-) diff --git a/CLAUDE.md b/CLAUDE.md index 3e7c79d9a3..c202195fc4 100644 --- a/CLAUDE.md +++ b/CLAUDE.md @@ -215,7 +215,7 @@ Current plan (see `ROADMAP.md` and the milestones): - **v2.x** (`main`, format v7) now gets only data-integrity and security fixes as patch releases (v2.0.3 is the first); v2.0.2 was the last planned v2.x release. - **v3.0.0** (format v8 and data integrity, tracker #383) is developed on the long-lived `v3` branch. All v3 PRs target `v3`; `main` stays untouched. CI runs on PRs to `v3` the same as on PRs to `main`. Do not merge `main` into `v3` routinely: `main` only gets backports of fixes already on `v3`. Shared CI and workflow changes land on both branches as separate PRs. Just before the v3.0.0 cut, merge `main` into `v3` once (merge commit; source conflicts resolved to `v3`, `main`'s v2.0.x CHANGELOG sections brought over) so the cut is a fast-forward. At the first v3 release, the current `main` is copied to `v2` and `v3` becomes the new `main`. - **v3.1.0** holds new features (query profiler #185, `:limit` #306/#310, lag/lead #182, UniFFI additions). -- Known v2.x data issue: same-transaction multi-valued facts (#371). Fix ships in v3.0.0. All v2.x known issues are listed in pinned issue #421 (`known-issue` label); `data-integrity`/`corruption`/`durability` issues stay open until the fix is in a published release (CONTRIBUTING.md). +- Known v2.x data issue: same-transaction multi-valued facts (#371). Fix ships in v3.0.0. All v2.x known issues are listed in pinned issue #421 (`known-issue` label); `data-integrity`/`corruption`/`durability` issues fixed in a v2.x patch stay open until that patch is published; issues fixed on the unreleased `v3` branch close on merge (closing keywords do not fire on `v3`, so close them with `gh issue close`) and stay listed in #421 (CONTRIBUTING.md). - Support policy and tiers: PHILOSOPHY.md §7 and §10. v2.x gets data-integrity and security fixes for 12 months after v3.0.0. Tier 1 = Rust + Python; other bindings are Tier 2. ## Testing Conventions diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 7cef6bf95b..93b8407bc2 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -93,7 +93,8 @@ Run branch coverage to check overall project health before submitting a PR. Bugs that can lose, corrupt or hide data are handled so that users can always see them before they adopt a release: -- An issue labelled `data-integrity`, `corruption` or `durability` stays **open until its fix is in a published release**, not just merged. The closing comment links that release. A fix merged only to a development branch (such as `v3`) does not close the issue. +- An issue labelled `data-integrity`, `corruption` or `durability` whose fix ships in a patch to a published line (such as v2.0.x) stays **open until that patch release is published**, not just merged. The closing comment links that release. +- A fix merged to a development branch whose first release has not shipped yet (such as `v3` before v3.0.0) closes its issue on merge: no released version of that line has the bug. If the bug also affects a published release, its entry in the pinned issue stays, with the fix version, until that release leaves support or gets the fix. - Every such bug that affects a published release also gets the `known-issue` label and an entry in the pinned [Known issues in the current release](https://github.com/project-minigraf/minigraf/issues/421) issue: affected versions, symptom, workaround and fix version. The entry is removed when the fix ships. - For bugs found downstream, the issue title or body states the affected version range (for example, "v0.6.0 – v2.0.1"). - The README links to the pinned issue from its "Known issues" section. diff --git a/docs/DURABILITY.md b/docs/DURABILITY.md index e572f73c28..607307f089 100644 --- a/docs/DURABILITY.md +++ b/docs/DURABILITY.md @@ -203,4 +203,4 @@ A write that returns an I/O error may still have committed (see [Failures while - **Rules and registered functions are not stored** in the file (#241). Register them after every open. - **Uncheckpointed transactions are held in memory.** A very large `wal_checkpoint_threshold` grows memory and WAL replay time with the pending transactions. A fact log or cursor left open keeps the transactions that were uncheckpointed when it opened in memory, and the pages later checkpoints replace in the file, until it is dropped; a crash or reopen frees those pages. -Open bugs that affect stored data or recovery carry the [`data-integrity`](https://github.com/project-minigraf/minigraf/issues?q=is%3Aopen+label%3Adata-integrity) and [`durability`](https://github.com/project-minigraf/minigraf/issues?q=is%3Aopen+label%3Adurability) labels; a fix merged for an unreleased version stays open until it ships. Bugs in the current published release, with workarounds and fix versions, are listed in [#421](https://github.com/project-minigraf/minigraf/issues/421). +Open bugs that affect stored data or recovery carry the [`data-integrity`](https://github.com/project-minigraf/minigraf/issues?q=is%3Aopen+label%3Adata-integrity) and [`durability`](https://github.com/project-minigraf/minigraf/issues?q=is%3Aopen+label%3Adurability) labels; a fix for a published line stays open until its patch release ships, while a fix on a branch with no release yet closes when it merges. Bugs in the current published release, with workarounds and fix versions, are listed in [#421](https://github.com/project-minigraf/minigraf/issues/421). From 2d7be4e25ce730330b668c59eed3d7617109e04f Mon Sep 17 00:00:00 2001 From: Aditya Mukhopadhyay Date: Wed, 14 Oct 2026 10:19:34 +0530 Subject: [PATCH 2/2] docs(contributing): leave #421 entry removal to the existing rule Co-Authored-By: Claude Opus 5.5 Claude-Session: https://claude.ai/code/session_01U611mBGbkSqJeSwNz2xd7s --- CONTRIBUTING.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 93b8407bc2..1b90f02a64 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -94,7 +94,7 @@ Run branch coverage to check overall project health before submitting a PR. Bugs that can lose, corrupt or hide data are handled so that users can always see them before they adopt a release: - An issue labelled `data-integrity`, `corruption` or `durability` whose fix ships in a patch to a published line (such as v2.0.x) stays **open until that patch release is published**, not just merged. The closing comment links that release. -- A fix merged to a development branch whose first release has not shipped yet (such as `v3` before v3.0.0) closes its issue on merge: no released version of that line has the bug. If the bug also affects a published release, its entry in the pinned issue stays, with the fix version, until that release leaves support or gets the fix. +- A fix merged to a development branch whose first release has not shipped yet (such as `v3` before v3.0.0) closes its issue on merge: no released version of that line has the bug. If the bug also affects a published release, it keeps its entry in the pinned issue, as below. - Every such bug that affects a published release also gets the `known-issue` label and an entry in the pinned [Known issues in the current release](https://github.com/project-minigraf/minigraf/issues/421) issue: affected versions, symptom, workaround and fix version. The entry is removed when the fix ships. - For bugs found downstream, the issue title or body states the affected version range (for example, "v0.6.0 – v2.0.1"). - The README links to the pinned issue from its "Known issues" section.