From 55d820e9d3b393878fe4449d27d27339212236fa Mon Sep 17 00:00:00 2001 From: Aditya Mukhopadhyay Date: Wed, 21 Oct 2026 13:12:40 +0530 Subject: [PATCH] ci(v3): make the binary-size gate report-only until #551 #549 PR 1 (#676) left the release binary at 1259 of 1260 KiB with #549 PR 2, #550 and #551 still to land while the engine and the executor both ship. The check still builds and prints the size and warns above the limit; it no longer fails. It returns to an enforced 1200 KiB when #551 removes the executor's query path. Co-Authored-By: Claude Opus 5.5 Claude-Session: https://claude.ai/code/session_019kY61Y11gcRD91Y6b7jbGT --- .github/workflows/binary-size.yml | 9 +++++++++ PHILOSOPHY.md | 2 +- 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/.github/workflows/binary-size.yml b/.github/workflows/binary-size.yml index 526d4bb9ed..a6ea934263 100644 --- a/.github/workflows/binary-size.yml +++ b/.github/workflows/binary-size.yml @@ -19,6 +19,11 @@ jobs: # 30 KiB more for rule queries on the engine, #548). Back to 1200 KiB when #551 # removes the executor's query path. See PHILOSOPHY.md ยง4. SIZE_LIMIT_BYTES: 1290240 + # Temporarily report-only on v3: #549 left the binary at 1259 of 1260 KiB with + # #549 PR 2, #550 and #551 still to land while both query paths ship. A size over + # the limit is a warning, not a failure. Set back to "fail", with a limit of + # 1228800 (1200 KiB), when #551 removes the executor's query path. + SIZE_GATE: report steps: - name: Checkout code uses: actions/checkout@v4 @@ -37,6 +42,10 @@ jobs: LIMIT_KB=$(( SIZE_LIMIT_BYTES / 1024 )) echo "Binary size: ${SIZE_KB} KiB (limit: ${LIMIT_KB} KiB)" if [ "$SIZE" -gt "$SIZE_LIMIT_BYTES" ]; then + if [ "$SIZE_GATE" = "report" ]; then + echo "::warning::binary size ${SIZE_KB} KiB exceeds limit of ${LIMIT_KB} KiB (gate is report-only until #551)" + exit 0 + fi echo "FAIL: binary size ${SIZE_KB} KiB exceeds limit of ${LIMIT_KB} KiB" exit 1 fi diff --git a/PHILOSOPHY.md b/PHILOSOPHY.md index bf1fdd350a..49a492dc42 100644 --- a/PHILOSOPHY.md +++ b/PHILOSOPHY.md @@ -115,7 +115,7 @@ SQLite's success comes from a clear philosophy: be a library, not a server. Be s strip=symbols all already applied; see CI's `binary-size.yml` for the enforced limit). On the v3 branch the gate allows a temporary 60 KiB more (1,260 KiB) while the streaming engine and the old executor both ship - (#473; rule queries on the engine added 30 KiB, #548); it returns to 1,200 KiB when #551 removes the executor's query path + (#473; rule queries on the engine added 30 KiB, #548), and since #549 left the binary at 1,259 KiB that gate is report-only: CI warns above 1,260 KiB instead of failing. It returns to an enforced 1,200 KiB when #551 removes the executor's query path - No runtime dependencies (no JVM, no Python, no Node.js) **Anti-pattern**: Requiring external services, libraries, or runtimes to function.