From 01631fafd6b056486497245c3df96bded194f4d3 Mon Sep 17 00:00:00 2001 From: Aditya Mukhopadhyay Date: Fri, 23 Oct 2026 08:26:28 +0530 Subject: [PATCH 1/2] ci(crash-kill): run v3's nightly rounds with test-oracle (#687) Scheduled workflows run the copy on the default branch, so v3's --features test-oracle change (#685) never reached the nightly v3 run and its Large variant (#550) did not run. Land v3's crash-kill.yml on main unchanged; main has no test-oracle feature and keeps its command. Closes #687 Co-Authored-By: Claude Opus 5.5 Claude-Session: https://claude.ai/code/session_019kY61Y11gcRD91Y6b7jbGT --- .github/workflows/crash-kill.yml | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/.github/workflows/crash-kill.yml b/.github/workflows/crash-kill.yml index fa72f14c7a..3f94c0aec7 100644 --- a/.github/workflows/crash-kill.yml +++ b/.github/workflows/crash-kill.yml @@ -64,7 +64,10 @@ jobs: RUST_BACKTRACE: 1 run: | set -o pipefail - cargo test --test crash_kill_test -- --nocapture 2>&1 | tee crash-kill-output.txt + # v3's large-transaction variant (#550) needs the test hooks. + features="" + if [ "$CRASH_REF" != main ]; then features="--features test-oracle"; fi + cargo test $features --test crash_kill_test -- --nocapture 2>&1 | tee crash-kill-output.txt - name: Record SIGKILL crash-safety failure if: ${{ failure() }} @@ -79,7 +82,7 @@ jobs: echo echo "- Run: $GITHUB_SERVER_URL/$GITHUB_REPOSITORY/actions/runs/$GITHUB_RUN_ID" echo "- Commit: $(git rev-parse HEAD)" - echo "- Reproduce: cargo test --test crash_kill_test -- --nocapture" + echo "- Reproduce: cargo test --test crash_kill_test -- --nocapture (v3: --features test-oracle)" echo " (set MINIGRAF_CRASH_KILL_ROUNDS to raise the round count; MINIGRAF_CRASH_KILL_SEED to the printed base seed to replay)" echo echo "## Test output" From f1c2a12e1c9439253ef2c615362fc4769244c51f Mon Sep 17 00:00:00 2001 From: Aditya Mukhopadhyay Date: Fri, 23 Oct 2026 08:30:38 +0530 Subject: [PATCH 2/2] ci(crash-kill): pass test-oracle wherever Cargo.toml defines it (#687) A dispatch on a main-based ref other than main would have passed a feature that does not exist there; a v3-based branch keeps the variant. Co-Authored-By: Claude Opus 5.5 Claude-Session: https://claude.ai/code/session_019kY61Y11gcRD91Y6b7jbGT --- .github/workflows/crash-kill.yml | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/.github/workflows/crash-kill.yml b/.github/workflows/crash-kill.yml index 3f94c0aec7..32e8bd8fa3 100644 --- a/.github/workflows/crash-kill.yml +++ b/.github/workflows/crash-kill.yml @@ -64,9 +64,10 @@ jobs: RUST_BACKTRACE: 1 run: | set -o pipefail - # v3's large-transaction variant (#550) needs the test hooks. + # v3's large-transaction variant (#550) needs the test hooks; pass + # the feature wherever the checked-out Cargo.toml defines it. features="" - if [ "$CRASH_REF" != main ]; then features="--features test-oracle"; fi + if grep -q '^test-oracle = ' Cargo.toml; then features="--features test-oracle"; fi cargo test $features --test crash_kill_test -- --nocapture 2>&1 | tee crash-kill-output.txt - name: Record SIGKILL crash-safety failure @@ -82,7 +83,7 @@ jobs: echo echo "- Run: $GITHUB_SERVER_URL/$GITHUB_REPOSITORY/actions/runs/$GITHUB_RUN_ID" echo "- Commit: $(git rev-parse HEAD)" - echo "- Reproduce: cargo test --test crash_kill_test -- --nocapture (v3: --features test-oracle)" + echo "- Reproduce: cargo test --test crash_kill_test -- --nocapture (add --features test-oracle where Cargo.toml defines it)" echo " (set MINIGRAF_CRASH_KILL_ROUNDS to raise the round count; MINIGRAF_CRASH_KILL_SEED to the printed base seed to replay)" echo echo "## Test output"