From 78179e837caac9e2b6c410665577b6165cfefa6a Mon Sep 17 00:00:00 2001 From: Aditya Mukhopadhyay Date: Fri, 23 Oct 2026 08:32:54 +0530 Subject: [PATCH] ci(crash-kill): pass test-oracle wherever Cargo.toml defines it (#687) Keeps crash-kill.yml identical on main and v3. Choosing the feature from the checked-out Cargo.toml, not the ref name, keeps a dispatch on a main-based branch from passing a feature it does not define. Co-Authored-By: Claude Opus 5.5 Claude-Session: https://claude.ai/code/session_019kY61Y11gcRD91Y6b7jbGT --- .github/workflows/crash-kill.yml | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/.github/workflows/crash-kill.yml b/.github/workflows/crash-kill.yml index 3f94c0aec7..32e8bd8fa3 100644 --- a/.github/workflows/crash-kill.yml +++ b/.github/workflows/crash-kill.yml @@ -64,9 +64,10 @@ jobs: RUST_BACKTRACE: 1 run: | set -o pipefail - # v3's large-transaction variant (#550) needs the test hooks. + # v3's large-transaction variant (#550) needs the test hooks; pass + # the feature wherever the checked-out Cargo.toml defines it. features="" - if [ "$CRASH_REF" != main ]; then features="--features test-oracle"; fi + if grep -q '^test-oracle = ' Cargo.toml; then features="--features test-oracle"; fi cargo test $features --test crash_kill_test -- --nocapture 2>&1 | tee crash-kill-output.txt - name: Record SIGKILL crash-safety failure @@ -82,7 +83,7 @@ jobs: echo echo "- Run: $GITHUB_SERVER_URL/$GITHUB_REPOSITORY/actions/runs/$GITHUB_RUN_ID" echo "- Commit: $(git rev-parse HEAD)" - echo "- Reproduce: cargo test --test crash_kill_test -- --nocapture (v3: --features test-oracle)" + echo "- Reproduce: cargo test --test crash_kill_test -- --nocapture (add --features test-oracle where Cargo.toml defines it)" echo " (set MINIGRAF_CRASH_KILL_ROUNDS to raise the round count; MINIGRAF_CRASH_KILL_SEED to the printed base seed to replay)" echo echo "## Test output"