Skip to content

feat(browser): BrowserDb binds sets (#316) - #753

Merged
adityamukho merged 2 commits into
v3from
feat/316-browser-set-bind
Oct 24, 2026
Merged

adityamukho merged 2 commits into
v3from
feat/316-browser-set-bind

Conversation

@adityamukho

Copy link
Copy Markdown
Collaborator

Step 21 of the #316 plan (PR 4): BrowserPreparedQuery bindings accept a set.

  • { type: 'set', value: [..] } or a JS Set → BindValue::Val(Value::Set(..)); elements are plain values or typed value forms.
  • An element in an entity/txCount/timestamp/anyValidTime form, or a non-array value, is API-017; a set inside a set is API-021 (ValueSet::new); a plain array (as a binding or an element) or any other non-bind value is a TypeError.
  • Tests: in? with typed sets, JS Sets, duplicates and empty sets; equality against a stored set-valued attribute with a keyword element; JSON array output in canonical order; every rejection path.

Browser tests: 43 pass locally (Firefox headless). Codex review: one finding, about the docs rather than the code (API-017 vs TypeError for unrecognized elements); wording fixed and cases added.

Part of #316.

🤖 Generated with Claude Code

https://claude.ai/code/session_01TcpoiFyFeQQQELL872LfQF

adityamukho and others added 2 commits October 25, 2026 01:57
A prepared query's binding can be {type: 'set', value: [..]} or a JS Set;
elements are plain or typed value forms. A non-value element is API-017,
a nested set API-021, a plain array a TypeError.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01TcpoiFyFeQQQELL872LfQF
@codecov

codecov Bot commented Oct 24, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@adityamukho
adityamukho merged commit 7cdfcb4 into v3 Oct 24, 2026
19 checks passed
@adityamukho
adityamukho deleted the feat/316-browser-set-bind branch October 24, 2026 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant