Repository navigation
fix(query): count window result columns against memory limit (#761) - #764
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This was referenced Oct 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
query_memory_limitwhile the input values and output rows coexist.try_reserveso allocation refusal returnsQRY-012; release column charges as results become cells and on errors, rewind, or close.Fixes #761.
Verification
cargo test --quieton bench machines1c44t88(exit 0)cargo clippy --all-features -- -D warningsons1c44t88(exit 0)cargo fmt --checkandgit diff --check(exit 0)Held::reserveandvalue_bytes.Scope
This covers retained result columns in
windows. The existing partition index, sorting scratch space, and user aggregate internals are outside this fix's scope.