Repository navigation
fix(query): count window partition scratch against memory limit (#765) - #766
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Value::Ordpartition equality, peer ranks, row-number tie breaks, and lag/lead adjacency.QRY-012.Fixes #765.
Verification
origin/v3, then passed with this change.cargo test --quietandcargo test --quiet --features test-hooksons1c44t88(both exit 0; 77 successful suite summaries and no failures in each run).cargo clippy --all-features -- -D warnings,cargo fmt --all --check, andgit diff --check.s1c44t88, one NUMA node, 10k rows, Criterion 10 samples / 1-second warm-up / 2-second measurement: rank 17.57 ms baseline → 17.68 ms fix; 10k distinct partitions 19.25 ms baseline → 19.22 ms fix.Held::charge,Held::uncharge, and the reserve-failure hook were checked against the code.Scope
The meter charges a per-entry estimate of index bytes, consistent with its other holders. Rust's
try_reserve_exactcan receive excess capacity from the allocator, which is outside that estimate. The existingvalue_ordercomparison forValue::Setstill builds temporary vectors. This change removeskeyed.sort_by's merge buffer and the unmetered partition map; it does not change the set comparator outside window partitioning.