Skip to content

feat(query): add bounded sliding row frames (#183) - #770

Merged
adityamukho merged 2 commits into
v3from
feat/183-row-frames
Oct 27, 2026
Merged

adityamukho merged 2 commits into
v3from
feat/183-row-frames

Conversation

@adityamukho

@adityamukho adityamukho commented Oct 27, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • Add :rows N preceding to aggregate windows, preserving the existing peer-based default and position functions.
  • Evaluate built-in bounded frames in linear time after sorting; replay middle-sized registered aggregate frames and use a linear path for prefix-covering frames.
  • Add parser errors PRS-124/PRS-125, strict grammar fixtures, exact numeric and plan-independence regressions, and query-memory accounting for min/max deques.
  • Document the feature and publish 128 reproducible timing/memory cases in docs/benchmarks/183-row-frames.csv.

Release target

Ship #183 in v3.0.0 on the v3 branch. No file-format change, new dependency, or version bump is included.

Verification

  • Full default suite: 1,885 passed, 15 ignored, 0 failed.
  • Full test-hooks suite: 1,917 passed, 16 ignored, 0 failed.
  • Native all-features, browser WASM, and WASI Clippy: passed with -D warnings.
  • Strict grammar corpus and bounded verifier: passed, including 1,387,336 structural inputs at bound 3.
  • Release binary: 1,253,760 bytes, under the 1,259,520-byte limit.
  • 128 Criterion cases, 10 samples each, on the designated idle bench machine pinned to one NUMA node: worst framed/default median 1.010× (limit 5×); worst 10k→100k growth 12.885× (limit 15×). Every case has a measured engine-meter peak in the CSV.
  • Claude independent read-only final review: approved; all concrete follow-ups addressed and rechecked.

Docs-site companion PR: project-minigraf/minigraf-docs#75

Refs #183.

@codecov

codecov Bot commented Oct 27, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 94.65649% with 14 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/query/datalog/aggregate.rs 92.99% 7 Missing and 4 partials ⚠️
src/query/datalog/parser.rs 96.84% 3 Missing ⚠️

📢 Thoughts on this report? Let us know!

@adityamukho
adityamukho marked this pull request as ready for review October 27, 2026 08:18
@adityamukho
adityamukho merged commit 8012075 into v3 Oct 27, 2026
19 checks passed
@adityamukho
adityamukho deleted the feat/183-row-frames branch October 27, 2026 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant