Repository navigation
ci: enforce named v3 acceptance tests and RSS evidence (#837) - #849
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
1 task done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The default-branch smoke workflow currently accepts successful Cargo commands even when they run zero intended tests or skip RSS assertions. Require the exact v3 acceptance inventory and measured RSS records. Run memory-sensitive suites serially and retain Cargo.lock with acceptance output.
Verification runs on a fresh runner that checks out only the workflow revision and reads current-run artifacts as data. This prevents the selected source from overwriting verifier code and resolves the two CodeQL cache-poisoning findings on the previous layout. Cache access remains disabled.
Closes #837. The prerequisite tests in #848 and historical audit in #847 are merged into v3. #850 mirrors the verifier isolation on v3.
Type of change
Validation
66962f56ddc75303eebe247159d915afa4420a23and sourcea2ac9545be7ee9bb62ca2d50ccd7b8bd6241ee3f; the verifier confirmed ten passing tests and nine measured RSS records.66962f56dwith no new alerts.docs/benchmarks/837-acceptance-gaps.mdand its evidence directory; ci: isolate acceptance verification on a fresh runner #850 records the isolation validation.Notes for reviewer
The exact inventory intentionally fails against older v3 sources. The verifier explicitly rejects failed acceptance jobs and missing artifacts. The dedicated dispatch validates the proposed workflow; scheduled activation follows merge. No main runtime, API, file format, or release changes.