Repository navigation
fix(browser): fail the IndexedDB handle after a failed flush and settle every flush (#894) - #903
Merged
Merged
Conversation
…le every flush (#894) An IndexedDB flush now lands whole or not at all and always settles. After a failed flush the handle rejects further writes, commits, checkpoints and imports with STG-046 until reopened; the failure itself is STG-048. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This was referenced Nov 18, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
An IndexedDB-backed
BrowserDbno longer acknowledges a write over pages that never reached IndexedDB (#894).STG-048naming the IndexedDB write and the DOM exception (e.g.QuotaExceededError). A preparation failure keeps its own code (e.g.INT-052).commit(),checkpoint()andimportGraph()reject withSTG-046and change nothing. Reads, cursors, prepared queries, rules,exportGraph()andclose()keep working. Reopen shows the state before the failed write.checkpoint()waits for earlier in-flight flushes;close()discards unstarted flushes withAPI-018. A failedopen()migration flush rejectsSTG-048.Verification
cargo test2,149 passed; clippy (native andwasm32-unknown-unknown --features browser) andcargo fmt --checkclean.wasm-pack test --headless: main-thread and worker lanes pass. Newflush_tests.rscases fail on unmodifiedv3(partial persistence, abort-only hang, queue-throw partial commit, successor submitted) and pass here.QuotaExceededErrorcase (CDP quota override) settles with STG-048 then STG-046; reopened stores pass the native integrity check.Refs #894 (stays open until a release ships the fix; the v2.x backport follows as a separate PR).
🤖 Generated with Claude Code