Skip to content

fix(browser): make the wasm32 browser library clippy-clean and lint it in CI - #905

Merged
adityamukho merged 1 commit into
mainfrom
fix/main-wasm-clippy
Nov 18, 2026
Merged

adityamukho merged 1 commit into
mainfrom
fix/main-wasm-clippy

Conversation

@adityamukho

Copy link
Copy Markdown
Collaborator

Summary

cargo clippy --target wasm32-unknown-unknown --features browser --lib -- -D warnings failed on main with about 32 errors, and no CI job linted the wasm32 build. This fixes the lints and adds the gate.

  • Behaviour-neutral fixes: cfg-gate native-only items that are unused on wasm32, use is_multiple_of and cast_signed. Where a fix would change behaviour (poisoned-lock panic, truncating Date::now() and IndexedDB-key conversions), a narrow #[allow] with a one-line reason keeps the current behaviour.
  • New Clippy (wasm32 browser library) job in lint.yml; its stale comment (it pointed at a wasm.yml that did not exist on main) is corrected.
  • No format, API or semantic change. Tests, benches and examples are untouched.

Verification

  • Rust 1.99.1: wasm32 clippy and cargo clippy --all-features -- -D warnings pass; cargo fmt --check clean.
  • cargo test: 1,326 passed, 9 ignored. Browser suite in Firefox (direct wasm-bindgen runner): 26 passed.

Follow-up to #904 (Evaluator gap on main's wasm lint). Separate from the browser-lanes PR.

🤖 Generated with Claude Code

…t in CI

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@codecov

codecov Bot commented Nov 18, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@adityamukho
adityamukho merged commit d5204f6 into main Nov 18, 2026
18 checks passed
@adityamukho
adityamukho deleted the fix/main-wasm-clippy branch November 18, 2026 03:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant