Skip to content

ci(browser): run the BrowserDb tests in Firefox, Chrome and Safari on main - #906

Merged
adityamukho merged 1 commit into
mainfrom
ci/main-wasm-browser-lanes
Nov 18, 2026
Merged

adityamukho merged 1 commit into
mainfrom
ci/main-wasm-browser-lanes

Conversation

@adityamukho

Copy link
Copy Markdown
Collaborator

Summary

main has no browser CI lane, so the v2 BrowserDb/IndexedDB tests (including the #894 flush tests) ran nowhere in CI. This adds .github/workflows/wasm.yml, modelled on the one on v3:

  • Browser tests in headless Firefox and Chrome (wasm-pack test --headless --features browser).
  • Safari main-thread lane on macos-15 through safaridriver.
  • No worker lanes: main's BrowserDb has no worker mode (no minigraf_browser_worker cfg), so there is nothing to run.
  • wasm-pack test could not build on main: native-only integration tests (error_codes_{foundation,storage,wal}_test.rs) and examples/pid_ns_helper.rs failed to compile for wasm32. They now carry the same wasm32 guards v3 uses. No runtime behaviour changes.
  • docs/TEST_COVERAGE.md documents the standard wasm-pack command; the lint.yml comment is corrected.

Verification

  • Local: wasm-pack test --headless --firefox --features browser passes (26 tests); native cargo test 1,326 passed, 9 ignored; cargo fmt --check clean.
  • Chrome and Safari cannot run locally; this PR's own CI is their first run.

Follow-up to #904 (Evaluator gap on main). Separate from the wasm clippy PR; the two edit the same lint.yml comment, so the second to merge needs a trivial rebase.

🤖 Generated with Claude Code

@codecov

codecov Bot commented Nov 18, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

… main

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@adityamukho
adityamukho force-pushed the ci/main-wasm-browser-lanes branch from bd0ec02 to 75be0ce Compare November 18, 2026 03:59
@adityamukho
adityamukho merged commit 55dca5e into main Nov 18, 2026
20 checks passed
@adityamukho
adityamukho deleted the ci/main-wasm-browser-lanes branch November 18, 2026 04:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant