Skip to content

test: fix wal_test cases still named/commented as crashes but no longer crash - #339

Merged
adityamukho merged 1 commit into
mainfrom
worktree-fix-wal-crash-naming-329
Aug 23, 2026
Merged

adityamukho merged 1 commit into
mainfrom
worktree-fix-wal-crash-naming-329

Conversation

@adityamukho

Copy link
Copy Markdown
Collaborator

Summary

  • Rename wal_recover_rollback_crash to wal_recover_rollback_not_persisted — it exercises a plain rollback + normal drop, not a real crashing subprocess.
  • Fix the self-contradicting comment ("Crash: skip Drop checkpoint. Nothing is pending though — ...") and its "after auto-checkpoint crash" assert message in test_auto_checkpoint_fires_at_threshold.
  • Fix the "after crash-reopen" assert message in test_manual_checkpoint_deletes_wal.

All other crash-labeled tests/comments in tests/wal_test.rs were audited and genuinely go through run_crashing_child (a real aborting subprocess), so they were left as-is.

Closes #329

Test plan

  • cargo test --test wal_test — 22 passed
  • cargo test (full suite) — all passing
  • pre-push hooks (fmt, clippy, full test suite) passed

…er crash (#329)

Three sites in tests/wal_test.rs assert through a live handle via a plain
drop(db), not a real crashing subprocess, but their naming and comments
still claimed a crash — misleading a reader scanning for crash-recovery
coverage.

- Rename wal_recover_rollback_crash to wal_recover_rollback_not_persisted
- Fix the self-contradicting "Crash: ... Nothing is pending though" comment
  and its "after auto-checkpoint crash" assert message
- Fix the "after crash-reopen" assert message in test_manual_checkpoint_deletes_wal
@codecov

codecov Bot commented Aug 23, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@adityamukho
adityamukho merged commit af68e8d into main Aug 23, 2026
17 checks passed
@adityamukho
adityamukho deleted the worktree-fix-wal-crash-naming-329 branch August 23, 2026 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test: three wal_test cases still named and commented as crashes but no longer crash

1 participant