Repository navigation
test: fix wal_test cases still named/commented as crashes but no longer crash - #339
Merged
Merged
Conversation
…er crash (#329) Three sites in tests/wal_test.rs assert through a live handle via a plain drop(db), not a real crashing subprocess, but their naming and comments still claimed a crash — misleading a reader scanning for crash-recovery coverage. - Rename wal_recover_rollback_crash to wal_recover_rollback_not_persisted - Fix the self-contradicting "Crash: ... Nothing is pending though" comment and its "after auto-checkpoint crash" assert message - Fix the "after crash-reopen" assert message in test_manual_checkpoint_deletes_wal
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
wal_recover_rollback_crashtowal_recover_rollback_not_persisted— it exercises a plain rollback + normal drop, not a real crashing subprocess.test_auto_checkpoint_fires_at_threshold.test_manual_checkpoint_deletes_wal.All other
crash-labeled tests/comments intests/wal_test.rswere audited and genuinely go throughrun_crashing_child(a real aborting subprocess), so they were left as-is.Closes #329
Test plan
cargo test --test wal_test— 22 passedcargo test(full suite) — all passing