Skip to content

docs: uneven and inaccurate compat test description in TEST_COVERAGE.md - #340

Merged
adityamukho merged 1 commit into
mainfrom
worktree-issue-331-testcoverage-docs
Aug 23, 2026
Merged

adityamukho merged 1 commit into
mainfrom
worktree-issue-331-testcoverage-docs

Conversation

@adityamukho

Copy link
Copy Markdown
Collaborator

Summary

  • Brings the nine older Datomic descriptions in docs/TEST_COVERAGE.md up to the depth of the newer ones — each now references the actual entities/values/assertions in the test.
  • Corrects xtdb_entity_reference_join's description, which called :dept :dept-eng a "reference-valued attribute" when it's a bare keyword, not a Value::Ref. Also corrects the source comment in tests/xtdb_compat_test.rs that the description was derived from.

Cosmetic only — no functional changes.

Fixes #331

Test plan

  • cargo test --test xtdb_compat_test --test datomic_compat_test — 25/25 passing

… description

Brings the nine older Datomic compat descriptions up to the depth of the
newer ones, and corrects xtdb_entity_reference_join's description and
source comment, which described a keyword-valued attribute as a
reference-valued one.

Fixes #331

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01YMWSutMLJJ7Y5b8hs9ZaCU
@codecov

codecov Bot commented Aug 23, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@adityamukho
adityamukho merged commit 4806119 into main Aug 23, 2026
17 checks passed
@adityamukho
adityamukho deleted the worktree-issue-331-testcoverage-docs branch August 23, 2026 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

docs: uneven and one inaccurate compat test description in TEST_COVERAGE.md

1 participant