Repository navigation
docs: add ERROR_REFERENCE.md codes for #303/#305 trailing-argument errors - #354
Merged
Merged
Conversation
…rors Adds PRS-075 through PRS-079 covering the parser error messages introduced by #303 (transact/retract trailing-argument rejection) and #305 (top-level/query/rule trailing-input rejection), neither of which updated the PRS-0xx taxonomy when merged. Sequenced before #277 per the issue's dependency note. Closes #352 Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Nsh3ZnmoK6PTaUbp4HcqHY
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
docs/ERROR_REFERENCE.mdfor the five user-facing parser error messages introduced by :valid-at appears to filter by transaction time instead of a fact's actual valid-from date #303 and Query parser silently discards trailing input after a complete form (garbage or documented clauses alike) #305 that were never documented in the PRS-0xx taxonomy.Closes #352
New codes
transactrejects unexpected trailing argument(s) (#303)retractrejects unexpected trailing argument(s) (#303)parse_ednrejects trailing input after a complete form (#305)queryrejects unexpected trailing argument(s) (#305)rulerejects unexpected trailing argument(s) (#305)Test plan
cargo fmt --check,cargo clippy,cargo test(pre-push hook) — all pass, 706+ tests greensrc/query/datalog/parser.rsand existing parser tests🤖 Generated with Claude Code
https://claude.ai/code/session_01Nsh3ZnmoK6PTaUbp4HcqHY