Repository navigation
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
The disabled path lacks regression coverage verifying that the app still renders with the module registered and enabled: false, while the Compodium renderer and API remain uninstalled.
1 open issue
What changed in this PR
Adds an opt-out for the Nuxt integration so applications can disable Compodium without removing it from the modules array.
Changes:
- Adds a documented
enabledoption that defaults totrue. - Returns early from module setup when disabled, preserving existing behavior by default.
| File | Description |
|---|---|
packages/nuxt/src/module.ts |
Defines the enabled option, its default, and the setup guard. |
Review effort: Balanced
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds an option to disable the module without the need to remove it from the
modulesarray.