Skip to content

fix(logging): explain ZIP and worker failures and memory pressure - #976

Open
tdurieux wants to merge 1 commit into
mainfrom
fix/zip-worker-diagnostics
Open

tdurieux wants to merge 1 commit into
mainfrom
fix/zip-worker-diagnostics

Conversation

@tdurieux

Copy link
Copy Markdown
Owner

Production ZIP failures were hard to diagnose: unsafe archive entries looked like invalid requested paths, worker failures lost their reason, and queued work timing out was reported as client cancellation.

Use a specific unsafe-ZIP-entry error while retaining fail-closed archive validation. Send only fixed failure codes across the worker boundary, preserve those codes through the collector and admin APIs, and distinguish queue timeout from cancellation. Add container cache and working-set measurements alongside total memory pressure; no memory limits or alert thresholds change.

Investigation linked the repeated path failures to one repository containing a backslash-bearing filename. This PR does not rename source files, skip unsafe entries, or claim to repair unknown historical worker failures. Existing discarded messages cannot be recovered. Mid-stream download failures still terminate the response rather than replacing already-sent ZIP bytes with JSON.

Validation: TypeScript and changed-file ESLint pass; 35 focused tests pass, including real worker failure sanitization, unsafe ZIP rejection without content leakage, submodules, and anonymization behavior. Pinned collector and both admin API regression results recorded separately below. No production changes.

Pinned Vector → VictoriaLogs and both safe admin API regression suite passed, including the new failure codes and memory fields.

@tdurieux

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown
Codex Review Summary: ❌ Failed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ❌ Failed 2026-11-19T15:04:28.908305Z
We couldn’t complete this review. Comment @codex review to try again.
b284bfb Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant