This repository was archived by the owner on Mar 11, 2021. It is now read-only.
Repository navigation
Revert TPU hack - #963
Closed
sethtroisi wants to merge 1 commit into
Closed
Revert TPU hack#963sethtroisi wants to merge 1 commit into
sethtroisi wants to merge 1 commit into
Conversation
Contributor
|
Thanks for the clean up but the TPU folks tell me that neither of the hacks in I'm going to close this PR because TPU best practices have changed a lot since I wrote |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original Hack added in #612
Closes #870