Skip to content

Drawer plans treat partial bins as full rectangles #246

Open

Description

@jasonmadigan

What

A bin with Partial Bins on and Connect base off prints without its disabled cells, so another bin can sit in those cells. Drawer plans still treat every bin as its full grid_x × grid_y rectangle. BinSummary doesn't carry partial_bins, partial_bins_values or partial_bins_connect, and binFootprint only reads the grid size, so:

  • findLayoutConflicts flags the pair as overlapping: red dashed outlines in 2D, red models in 3D and "2 overlapping" under Space usage, although the printed bins fit.
  • drawerStats counts disabled cells as used.
  • findFreeSpot, and autoArrange through it, never place a bin in disabled cells.
  • The 2D canvas draws the full rectangle, so the plan doesn't show the shape that prints. The 3D view already does, because it renders the generated STL.

With Connect base on, disabled cells keep a base plate, so they are still occupied and the full rectangle is correct there.

Reproduce

  1. Make a 6×2 bin with a tool along the top row only. Turn on Partial Bins, switch off the two left cells of the bottom row and leave Connect base off.
  2. Make a 5×6 bin with a tool reaching into its top-right corner.
  3. In a 9×7 drawer plan, place the 5×6 bin at (0, 1) and the 6×2 bin at (3, 0), so the disabled cells sit over the other bin's top-right corner.

Both placements are flagged as overlapping. The 3D view shows the L-shaped model wrapped around the other bin's corner without intersecting it.

Acceptance criteria

  • Bin summaries expose the disabled cells, or an equivalent footprint, for bins with Connect base off.
  • Conflict detection, space usage, first-free-spot placement and auto arrange use the rectangles of the cells a bin occupies, rotated with the placement. Partial bin cells are always 42mm, including on half-grid bins placed at half-unit offsets. On fractional grid sizes the narrow column is on the right and the narrow row at the top, matching _cell_center and _partial_cell_index.
  • The 2D canvas draws disabled cells as empty.
  • Bins with Connect base on keep their full footprint.
  • Tests cover a rotated partial bin interlocking with a neighbour, and a genuine overlap involving a partial bin that is still flagged.

Related: a disabled cell is cut as a full 42mm square on the grid line (_make_disabled_cell_cutters), so a neighbour sitting in disabled cells has 0.25mm clearance on that face instead of the 0.5mm between two whole bins.

Activity

  1. added
    bugSomething isn't working
    scope:in-scopeFits the product constitution; eligible for prioritisation, not promised
    on Nov 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

bugSomething isn't workingscope:in-scopeFits the product constitution; eligible for prioritisation, not promised

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions