Skip to content

Connect base leaves the base of each switched-off cell as a loose block #263

Open

Description

@jasonmadigan

With Partial Bins and Connect base on, _make_connect_mode_cell_cutters in backend/app/services/stl_generator_manifold.py cuts each disabled cell from GF_BASE_HEIGHT - 0.1 (4.65 mm) upwards, and _make_connect_mode_stability_plates adds the bridging plate from GF_BASE_HEIGHT (4.75 mm). The base left in a disabled cell stops 0.1 mm below the plate and touches nothing else, so it exports as a separate body. The toggle's help text promises "one connected print".

Reproduction

  1. Make a 2×1 bin, Height 3, Magnet holes off, with Partial Bins on, the right cell off and Connect base on.
  2. Generate it and count the bodies in the STL.

There are two. The second is the right cell's base: z 0 to 4.65 mm, 6643 mm³. Horizontal slices through that cell have material at 4.64 and 4.76 mm and none at 4.66, 4.70 or 4.74 mm.

Layout Bodies
2×1, right cell off 2
2×1, right cell off, Retain outer wall on 1
3×3, centre cell off, Retain outer wall on 2
2×4, second row off 3

Retain outer wall joins an edge cell's base to the bin through the kept wall strip. An interior cell's base stays loose.

Expected

One body. The base of each disabled cell is joined to the plate above it.

Notes

  • docs/stl-generation.md says the wall cutters start at BASE_HEIGHT. Patched in memory to start there, or with the plates starting at 4.65 mm, every layout in the table exports one body.
  • test_partial_bins_connect_keeps_single_piece uses the 2×4 layout and passes without counting the bodies of the Connect base result: its export_split_parts assertion holds because Connect base skips decomposition.
  • test_connect_mode_split_uses_full_grid_footprint (3×3, one cell on, Connect base on) builds nine bodies, eight of them loose bases, and only asserts that some parts are returned.
  • Draft Shell Mode #215 rewrites these lines with the cutters at base_top - 0.1 and the plates at base_top, so the gap survives it.

Seen on main at a73e0e6 (0.11.0).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

bugSomething isn't workingscope:in-scopeFits the product constitution; eligible for prioritisation, not promised

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions