Skip to content

Test pocket depth in split ZIP exports - #235

Merged
jasonmadigan merged 1 commit into
mainfrom
fix/230-split-pocket-depth
Oct 7, 2026
Merged

jasonmadigan merged 1 commit into
mainfrom
fix/230-split-pocket-depth

Conversation

@jasonmadigan

Copy link
Copy Markdown
Collaborator

Summary

  • Before Fix sizing errors in scans and STL exports #234, an older split export could replace the ZIP after a newer job wrote the full STL. Replaying a depth change from 17.45 mm to 12 mm leaves a correct 12 mm full STL alongside 17.45 mm ZIP parts.
  • The generation lock in Fix sizing errors in scans and STL exports #234 already fixes this. Add four regression tests that measure the downloaded full STL and both ZIP parts. They cover overlapping bin and session exports, per-tool depth overrides, saved edits and cached downloads.

Test evidence

  • Historical replay at 13a00d3: reproduced twice. Current main (03badee1): all downloads measure 12.00 mm. Disabling only the export lock brings back the mismatch.
  • Backend python -m pytest -q: 852 passed.
  • Frontend pnpm test: 275 passed.
  • make lint: passed, with nine existing warnings.
  • make test-e2e-accuracy: five passed.

Closes #230

An older split job could leave 17.45 mm ZIP pockets beside a full STL
that already contained the new 12 mm pockets. The export lock in #234
prevents that mismatch.

Measure both downloads after overlapping bin and session exports, saved
depth changes, per-tool overrides and cached generation.

Signed-off-by: Jason Madigan <jason@jasonmadigan.com>
@jasonmadigan
jasonmadigan marked this pull request as ready for review October 7, 2026 12:35
@jasonmadigan
jasonmadigan merged commit 55af339 into main Oct 7, 2026
6 checks passed
@jasonmadigan
jasonmadigan deleted the fix/230-split-pocket-depth branch October 7, 2026 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Pocket depth not honored in zip file

1 participant