Repository navigation
Test pocket depth in split ZIP exports - #235
Merged
Merged
Conversation
An older split job could leave 17.45 mm ZIP pockets beside a full STL that already contained the new 12 mm pockets. The export lock in #234 prevents that mismatch. Measure both downloads after overlapping bin and session exports, saved depth changes, per-tool overrides and cached generation. Signed-off-by: Jason Madigan <jason@jasonmadigan.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test evidence
13a00d3: reproduced twice. Currentmain(03badee1): all downloads measure 12.00 mm. Disabling only the export lock brings back the mismatch.python -m pytest -q: 852 passed.pnpm test: 275 passed.make lint: passed, with nine existing warnings.make test-e2e-accuracy: five passed.Closes #230