Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tool tags already persist through the API but cannot be edited or used to narrow tool lists. Add free-form tag editing to the tool page and show tags on library cards, using the existing storage and API fields. Adding trims whitespace and removes case-insensitive duplicates while preserving spaces within a tag.
An inline Tags button beside the library status filters opens a searchable list with multiple selections. Matching is exact and case-insensitive: a tool must match any selected tag as well as the existing name and placement filters. Clear tags removes only the tag selection. Project tools and Add tools have independent tag filters, with choices drawn from their respective lists; Add-tools Select all uses the filtered list, while Project tools Select visible includes only matching unplaced tools.
Both project tool sections follow the main-page layout: search and actions beside the heading, filters below. The selected-for-bin count precedes Search. Add tools reuses the shared header's expandable search and count badge, including its convention of hiding zero counts. Header controls can wrap when space is limited. The picker supports Escape with focus return, outside-click dismissal and clearing a selection whose tag is no longer present.
The tool page also preserves edits made immediately after loading, avoids rewriting an unchanged tool on open, flushes queued edits on departure, and shows failed saves with a retry action. Tool state is scoped by ID so late loads cannot replace another tool after navigation. These save behaviours apply to outline edits as well as tags. No migration, new store or dependency is introduced.
Closes #171.
Validation:
cd backend && STORAGE_PATH=<isolated directory> AUTH_MODE=open venv/bin/python -m pytest— 854 passed. Covers tag update/clear persistence after reopening the store and preservation of outline/category data.pnpm --dir frontend test— 288 passed. Covers tag matching, search/multiple selection/clearing, removed tags, keyboard focus, project filter composition, visible unplaced selection, immediate edits and failed-save retry.make lint— backend lint, frontend lint and TypeScript passed; 9 existing frontend warnings.Validation ran on macOS with Python 3.12 and the repository-declared pnpm 10.29.2. The complete Playwright workflow and physical export checks run in GitHub Actions. Earlier local headless preview steps reported WebGL context errors; a passing canvas-visibility check does not establish successful 3D rendering in that environment.