Skip to content

Add tool tags and searchable library and project filters - #241

Draft
noobydp wants to merge 2 commits into
tracefinity:mainfrom
noobydp:feat/tool-tags
Draft

noobydp wants to merge 2 commits into
tracefinity:mainfrom
noobydp:feat/tool-tags

Conversation

@noobydp

@noobydp noobydp commented Oct 25, 2026 •

Copy link
Copy Markdown
Contributor

Tool tags already persist through the API but cannot be edited or used to narrow tool lists. Add free-form tag editing to the tool page and show tags on library cards, using the existing storage and API fields. Adding trims whitespace and removes case-insensitive duplicates while preserving spaces within a tag.

An inline Tags button beside the library status filters opens a searchable list with multiple selections. Matching is exact and case-insensitive: a tool must match any selected tag as well as the existing name and placement filters. Clear tags removes only the tag selection. Project tools and Add tools have independent tag filters, with choices drawn from their respective lists; Add-tools Select all uses the filtered list, while Project tools Select visible includes only matching unplaced tools.

Both project tool sections follow the main-page layout: search and actions beside the heading, filters below. The selected-for-bin count precedes Search. Add tools reuses the shared header's expandable search and count badge, including its convention of hiding zero counts. Header controls can wrap when space is limited. The picker supports Escape with focus return, outside-click dismissal and clearing a selection whose tag is no longer present.

The tool page also preserves edits made immediately after loading, avoids rewriting an unchanged tool on open, flushes queued edits on departure, and shows failed saves with a retry action. Tool state is scoped by ID so late loads cannot replace another tool after navigation. These save behaviours apply to outline edits as well as tags. No migration, new store or dependency is introduced.

Closes #171.

Validation:

  • Complete backend suite: cd backend && STORAGE_PATH=<isolated directory> AUTH_MODE=open venv/bin/python -m pytest — 854 passed. Covers tag update/clear persistence after reopening the store and preservation of outline/category data.
  • Complete frontend suite: pnpm --dir frontend test — 288 passed. Covers tag matching, search/multiple selection/clearing, removed tags, keyboard focus, project filter composition, visible unplaced selection, immediate edits and failed-save retry.
  • make lint — backend lint, frontend lint and TypeScript passed; 9 existing frontend warnings.
  • Running frontend/backend browser checks confirmed tag search and multiple selections, composition with name/status, clearing only tags, independent project lists, and the reviewed header layout/search behaviour.

Validation ran on macOS with Python 3.12 and the repository-declared pnpm 10.29.2. The complete Playwright workflow and physical export checks run in GitHub Actions. Earlier local headless preview steps reported WebGL context errors; a passing canvas-visibility check does not establish successful 3D rendering in that environment.

@noobydp noobydp changed the title Add tool tag editing and library filtering Add tool tags and searchable library and project filters Oct 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature Request: Add free-form tags/categories to tools

1 participant