Repository navigation
Conversation
go-lint: install golangci-lint from golangci-lint.run (the master install.sh fails its checksum for v2.15.0), drop --out-format, which v2 removed, and drop a duplicate import of apis/minio/v1 that staticcheck reports (ST1019). E2E: pin the Crossplane chart to 1.20.1. The latest chart installs Crossplane v2, which exits on --enable-composition-revisions. open-pr-component: check out component-appcat with history and tags, so git describe in make gen-golden-all finds a tag. Signed-off-by: Aarno Aukia <aarno.aukia@vshn.ch> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
🟢 Approval recommended
The review identifies no active issues requiring changes.
No open issues 🎉
What changed in this PR
This PR addresses failures in Go linting, Crossplane E2E setup, and component pull-request generation in CI.
Changes:
- Updates the golangci-lint installer URL, removes an unsupported v2 flag, and consolidates duplicate Go imports.
- Pins the Crossplane chart to
1.20.1to retain compatibility with the existing startup flags. - Fetches full component repository history and tags for golden-file generation.
| File | Description |
|---|---|
test/local.mk |
Pins Crossplane to 1.20.1 and documents the compatibility reason. |
operator/policy/delete.go |
Removes the duplicate import and uses the existing miniov1 alias. |
Makefile |
Changes the linter installer URL and removes --out-format. |
.github/workflows/pr.yml |
Enables full checkout history and explicitly fetches tags. |
Review effort: Balanced
helm.twun.io no longer serves the docker-registry chart (EOF on index.yaml); provider-s3 already uses twuni.github.io/docker-registry.helm. MinIO stopped publishing community images, so the minio and mc images that chart 5.0.7 pins no longer resolve and the server never starts. Use Chainguard's minio image, which contains minio, mc and a shell, for both, and skip the chart's default console user: the job that creates it writes to /etc/minio, which the non-root image cannot, and the tests log in as root. Signed-off-by: Aarno Aukia <aarno.aukia@vshn.ch> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
VSHN's MinIO rebuild is pinned to a release and runs as root, so the chart's default console-user job works again and users: [] can go. k8up's E2E uses the same image for server and mc. Signed-off-by: Aarno Aukia <aarno.aukia@vshn.ch> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
With ghcr.io/vshn/minio the chart's post-install job still never completes (E2E run 42349664369). The tests log in as the root user, so the extra user is not needed. Signed-off-by: Aarno Aukia <aarno.aukia@vshn.ch> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Renovate only read go.mod and the workflows, so the kind node image, the E2E Helm charts, crank and the Antora images never got updates. Each pin is now a Make variable with a renovate: comment above it, read by one regex manager. Crossplane and crank stay below v2. Signed-off-by: Aarno Aukia <aarno.aukia@vshn.ch> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The regex manager's default versioning drops the fourth component, so 3.1.14 and 3.1.14.1 compared equal and revision releases never got a PR. loose versioning compares all four. Signed-off-by: Aarno Aukia <aarno.aukia@vshn.ch> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Three checks fail on every PR here. This fixes all three, one commit's worth each:
go-lint. Two problems, both hidden by the first:raw.githubusercontent.com/golangci/golangci-lint/master/install.sh, and its v2.15.0 download fails the checksum check (hash_sha256_verify ... did not verify).vshn/provider-s3andvshn/provider-exoscaleusehttps://golangci-lint.run/install.sh, which installs the same version and passes. Switched to that.--out-format colored-line-number(removed in v2), and staticcheck reports one finding:operator/policy/delete.goimportsapis/minio/v1twice, asmetav1andminiov1(ST1019). Dropped the flag and the duplicate alias.test-e2e.crossplane-setupinstalls whatever the chart's latest version is, today Crossplane 2.4.3, and v2 exits on--enable-composition-revisions:The pod crash-loops and
helm --waittimes out after 5 minutes. Pinned the chart to1.20.1, the last v1 release, which keeps the flag.With Crossplane up, two more setup steps failed in turn (second commit):
registry-setup:helm.twun.iono longer serves the docker-registry chart (Get "https://helm.twun.io/index.yaml": EOF). Switched tohttps://twuni.github.io/docker-registry.helm, whichvshn/provider-s3already uses.minio-setup: MinIO stopped publishing community images. Neither tag that chart 5.0.7 pins (quay.io/minio/minio:RELEASE.2023-02-10T18-48-39Z,quay.io/minio/mc:RELEASE.2023-01-28T20-29-38Z) resolves any more, nor:lateston quay.io or Docker Hub.test/minio/values.yamlnow usesghcr.io/vshn/minio:RELEASE.2025-09-07T16-13-09Z, VSHN's rebuild withminio,mcand a shell, for both the server and the chart'smcimage, as k8up's E2E does (e2e/definitions/minio/helm.yaml). It also setsusers: []: the chart's post-install job that creates the defaultconsoleuser never completes on kind, with the Chainguard image or with this one (run 42349664369). The tests log in as the root user, so that user is not needed.open-pr-component. The job checks outvshn/component-appcatshallow and without tags, andmake gen-golden-allfails inhack/getversionlist.pywithfatal: No names found, cannot describe anything. Addedfetch-depth: 0and a tag fetch, asvshn/provider-cloudscalehas.Verification
go build ./...,go vet ./operator/policy/andgolangci-lint runv2.15.0 locally after the change:0 issues.kindest/node:v1.28.9, the CI's version: chart 2.4.3 with these flags isCrashLoopBackOffwith the error above; chart 1.20.1 with the same flags is ready.open-pr-component: opening this PR runs the fixed job once. If it then fails at "Create Pull Request", that is the push tocomponent-appcatwithCOMPONENT_ACCESS_TOKEN, which fails withcould not read Usernamein provider-cloudscale.ImagePullBackOff. Chainguard's image withusers: []completedhelm install; this PR first used it, then switched toghcr.io/vshn/miniobecause that is pinned to a release. E2E passes with it (run 42350308971).Note on the label
The label check accepts
major,minor,patch,documentationordependency, andcreate-releasetags a release for each of them on merge. This PR is labeledpatch, so merging it cuts a patch release.Fixes the red checks on PR 87. Found while working on vshn/antora-ui#204.
Renovate: version pins in Makefiles (third commit)
renovate.jsononly covered Go modules and workflows. Version pins in the Makefiles never got an update PR. This PR turns each pin into a Make variable with a# renovate: datasource=… depName=…comment directly above it, and adds one regex manager that reads that pattern inMakefileand*.mk.KIND_NODE_VERSIONMakefile.vars.mkdocker.io/kindest/nodeCROSSPLANE_VERSION(was inline--version 1.20.1)Makefile.vars.mk, used intest/local.mkcrossplanefrom charts.crossplane.io/stableMINIO_CHART_VERSION(was inline--version 5.0.7)Makefile.vars.mk, used intest/local.mkminiofrom charts.min.ioCRANK_VERSION(was inlinecrank@v1.16.0, twice)ci.mkgithub.com/crossplane/crossplaneantora_build_versiondocs/antora-build.mkghcr.io/vshn/antoraantora_preview_versiondocs/antora-preview.mkghcr.io/vshn/antora-previewcrank stays below v2 (
packageRules). The go datasource also offers v2.4.3, but crank v2 lives in thegithub.com/crossplane/crossplane/v2module, sogo run …/cmd/crank@v2.xon the v1 path would fail.Antora tags are compared with
looseversioning (packageRules). The regex manager's default drops the fourth part of3.1.14.1, so3.1.14and3.1.14.1compared equal and revision releases never produced a PR. Withloose, the lookup offers 3.1.14.1 for both Antora images.Crossplane stays below v2 (
packageRules,allowedVersions: "<2"). The E2E setup needs v1 until it moves to v2 as its own piece of work. Within 1.x Renovate proposes 1.20.14.Not tracked: the MinIO image in
test/minio/values.yaml.config:baseignores everything undertest/, and even with that lifted Renovate rejects theRELEASE.2025-09-07T16-13-09Ztag asinvalid-valuefor Docker versioning.ghcr.io/vshn/miniohas only that one tag anyway, so this pin moves by hand.Not tracked: the twuni registry chart is installed without
--version, so there is no pin to track.ENVTEST_K8S_VERSIONis a wildcard (1.x.x) forsetup-envtest, not a Renovate-shaped version.No automerge.
e2e.ymlruns on every push, so E2E runs on each Renovate PR, except bumps underdocs/(the Antora pins), which it ignores. Note that the label check andcreate-releasecut a release when any PR merges, Renovate'sdependency-labeled PRs included.Verification
renovate-config-validator(Renovate 44.222.0) accepts the config.renovate --platform=local --dry-run=lookupon the changed files lists exactly the pins in the table above, with the updates shown. Renovate exited 1 because the local Node (25.9.0) is outside its supported range, after writing the report. The hosted app's first run is the real check.🤖 Generated with Claude Code