Skip to content

Fix go-lint, E2E setup and open-pr-component in CI - #88

Open
arska wants to merge 6 commits into
masterfrom
fix-ci
Open

arska wants to merge 6 commits into
masterfrom
fix-ci

Conversation

@arska

@arska arska commented Nov 6, 2026 •

Copy link
Copy Markdown
Member

Summary

Three checks fail on every PR here. This fixes all three, one commit's worth each:

go-lint. Two problems, both hidden by the first:

  1. The Makefile fetches the installer from raw.githubusercontent.com/golangci/golangci-lint/master/install.sh, and its v2.15.0 download fails the checksum check (hash_sha256_verify ... did not verify). vshn/provider-s3 and vshn/provider-exoscale use https://golangci-lint.run/install.sh, which installs the same version and passes. Switched to that.
  2. Once it installs, v2 rejects --out-format colored-line-number (removed in v2), and staticcheck reports one finding: operator/policy/delete.go imports apis/minio/v1 twice, as metav1 and miniov1 (ST1019). Dropped the flag and the duplicate alias.

test-e2e. crossplane-setup installs whatever the chart's latest version is, today Crossplane 2.4.3, and v2 exits on --enable-composition-revisions:

crossplane: error: unknown flag --enable-composition-revisions

The pod crash-loops and helm --wait times out after 5 minutes. Pinned the chart to 1.20.1, the last v1 release, which keeps the flag.

With Crossplane up, two more setup steps failed in turn (second commit):

  • registry-setup: helm.twun.io no longer serves the docker-registry chart (Get "https://helm.twun.io/index.yaml": EOF). Switched to https://twuni.github.io/docker-registry.helm, which vshn/provider-s3 already uses.
  • minio-setup: MinIO stopped publishing community images. Neither tag that chart 5.0.7 pins (quay.io/minio/minio:RELEASE.2023-02-10T18-48-39Z, quay.io/minio/mc:RELEASE.2023-01-28T20-29-38Z) resolves any more, nor :latest on quay.io or Docker Hub. test/minio/values.yaml now uses ghcr.io/vshn/minio:RELEASE.2025-09-07T16-13-09Z, VSHN's rebuild with minio, mc and a shell, for both the server and the chart's mc image, as k8up's E2E does (e2e/definitions/minio/helm.yaml). It also sets users: []: the chart's post-install job that creates the default console user never completes on kind, with the Chainguard image or with this one (run 42349664369). The tests log in as the root user, so that user is not needed.

open-pr-component. The job checks out vshn/component-appcat shallow and without tags, and make gen-golden-all fails in hack/getversionlist.py with fatal: No names found, cannot describe anything. Added fetch-depth: 0 and a tag fetch, as vshn/provider-cloudscale has.

Verification

  • go build ./..., go vet ./operator/policy/ and golangci-lint run v2.15.0 locally after the change: 0 issues.
  • Crossplane reproduced on kind with kindest/node:v1.28.9, the CI's version: chart 2.4.3 with these flags is CrashLoopBackOff with the error above; chart 1.20.1 with the same flags is ready.
  • open-pr-component: opening this PR runs the fixed job once. If it then fails at "Create Pull Request", that is the push to component-appcat with COMPONENT_ACCESS_TOKEN, which fails with could not read Username in provider-cloudscale.
  • E2E passes on this PR (run 42317692845), setup and tests, for the first time in this repository's recent history.
  • MinIO on kind: with the original values both pods sit in ImagePullBackOff. Chainguard's image with users: [] completed helm install; this PR first used it, then switched to ghcr.io/vshn/minio because that is pinned to a release. E2E passes with it (run 42350308971).

Note on the label

The label check accepts major, minor, patch, documentation or dependency, and create-release tags a release for each of them on merge. This PR is labeled patch, so merging it cuts a patch release.

Fixes the red checks on PR 87. Found while working on vshn/antora-ui#204.

Renovate: version pins in Makefiles (third commit)

renovate.json only covered Go modules and workflows. Version pins in the Makefiles never got an update PR. This PR turns each pin into a Make variable with a # renovate: datasource=… depName=… comment directly above it, and adds one regex manager that reads that pattern in Makefile and *.mk.

Pin File Datasource Update Renovate finds today
kind node image KIND_NODE_VERSION Makefile.vars.mk docker docker.io/kindest/node v1.37.0
Crossplane chart CROSSPLANE_VERSION (was inline --version 1.20.1) Makefile.vars.mk, used in test/local.mk helm crossplane from charts.crossplane.io/stable 1.20.14 (capped below 2)
MinIO chart MINIO_CHART_VERSION (was inline --version 5.0.7) Makefile.vars.mk, used in test/local.mk helm minio from charts.min.io 5.4.0
crank CRANK_VERSION (was inline crank@v1.16.0, twice) ci.mk go github.com/crossplane/crossplane v1.20.14
Antora antora_build_version docs/antora-build.mk docker ghcr.io/vshn/antora 3.1.14.1
Antora preview antora_preview_version docs/antora-preview.mk docker ghcr.io/vshn/antora-preview 3.1.14.1

crank stays below v2 (packageRules). The go datasource also offers v2.4.3, but crank v2 lives in the github.com/crossplane/crossplane/v2 module, so go run …/cmd/crank@v2.x on the v1 path would fail.

Antora tags are compared with loose versioning (packageRules). The regex manager's default drops the fourth part of 3.1.14.1, so 3.1.14 and 3.1.14.1 compared equal and revision releases never produced a PR. With loose, the lookup offers 3.1.14.1 for both Antora images.

Crossplane stays below v2 (packageRules, allowedVersions: "<2"). The E2E setup needs v1 until it moves to v2 as its own piece of work. Within 1.x Renovate proposes 1.20.14.

Not tracked: the MinIO image in test/minio/values.yaml. config:base ignores everything under test/, and even with that lifted Renovate rejects the RELEASE.2025-09-07T16-13-09Z tag as invalid-value for Docker versioning. ghcr.io/vshn/minio has only that one tag anyway, so this pin moves by hand.

Not tracked: the twuni registry chart is installed without --version, so there is no pin to track. ENVTEST_K8S_VERSION is a wildcard (1.x.x) for setup-envtest, not a Renovate-shaped version.

No automerge. e2e.yml runs on every push, so E2E runs on each Renovate PR, except bumps under docs/ (the Antora pins), which it ignores. Note that the label check and create-release cut a release when any PR merges, Renovate's dependency-labeled PRs included.

Verification

  • renovate-config-validator (Renovate 44.222.0) accepts the config.
  • renovate --platform=local --dry-run=lookup on the changed files lists exactly the pins in the table above, with the updates shown. Renovate exited 1 because the local Node (25.9.0) is outside its supported range, after writing the report. The hosted app's first run is the real check.

🤖 Generated with Claude Code

go-lint: install golangci-lint from golangci-lint.run (the master
install.sh fails its checksum for v2.15.0), drop --out-format, which v2
removed, and drop a duplicate import of apis/minio/v1 that staticcheck
reports (ST1019).

E2E: pin the Crossplane chart to 1.20.1. The latest chart installs
Crossplane v2, which exits on --enable-composition-revisions.

open-pr-component: check out component-appcat with history and tags, so
git describe in make gen-golden-all finds a tag.

Signed-off-by: Aarno Aukia <aarno.aukia@vshn.ch>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Copilot AI balanced review requested due to automatic review settings November 6, 2026 23:53
@arska arska added the patch label Nov 6, 2026
@arska arska self-assigned this Nov 6, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The review identifies no active issues requiring changes.

No open issues 🎉

What changed in this PR

This PR addresses failures in Go linting, Crossplane E2E setup, and component pull-request generation in CI.

Changes:

  • Updates the golangci-lint installer URL, removes an unsupported v2 flag, and consolidates duplicate Go imports.
  • Pins the Crossplane chart to 1.20.1 to retain compatibility with the existing startup flags.
  • Fetches full component repository history and tags for golden-file generation.
File Description
test/​local.mk Pins Crossplane to 1.20.1 and documents the compatibility reason.
operator/​policy/​delete.go Removes the duplicate import and uses the existing miniov1 alias.
Makefile Changes the linter installer URL and removes --out-format.
.github/​workflows/​pr.yml Enables full checkout history and explicitly fetches tags.

Review effort: Balanced

helm.twun.io no longer serves the docker-registry chart (EOF on
index.yaml); provider-s3 already uses twuni.github.io/docker-registry.helm.

MinIO stopped publishing community images, so the minio and mc images
that chart 5.0.7 pins no longer resolve and the server never starts.
Use Chainguard's minio image, which contains minio, mc and a shell, for
both, and skip the chart's default console user: the job that creates it
writes to /etc/minio, which the non-root image cannot, and the tests log
in as root.

Signed-off-by: Aarno Aukia <aarno.aukia@vshn.ch>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
arska and others added 4 commits November 7, 2026 08:03
VSHN's MinIO rebuild is pinned to a release and runs as root, so the
chart's default console-user job works again and users: [] can go.
k8up's E2E uses the same image for server and mc.

Signed-off-by: Aarno Aukia <aarno.aukia@vshn.ch>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
With ghcr.io/vshn/minio the chart's post-install job still never
completes (E2E run 42349664369). The tests log in as the root user,
so the extra user is not needed.

Signed-off-by: Aarno Aukia <aarno.aukia@vshn.ch>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Renovate only read go.mod and the workflows, so the kind node image,
the E2E Helm charts, crank and the Antora images never got updates.
Each pin is now a Make variable with a renovate: comment above it, read
by one regex manager. Crossplane and crank stay below v2.

Signed-off-by: Aarno Aukia <aarno.aukia@vshn.ch>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The regex manager's default versioning drops the fourth component, so
3.1.14 and 3.1.14.1 compared equal and revision releases never got a
PR. loose versioning compares all four.

Signed-off-by: Aarno Aukia <aarno.aukia@vshn.ch>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants