Skip to content

Fixes for make targets concerning the release flow - #24

Merged
Kidswiss merged 1 commit into
masterfrom
fix/release
Sep 8, 2023
Merged

Kidswiss merged 1 commit into
masterfrom
fix/release

Conversation

@Kidswiss

@Kidswiss Kidswiss commented Sep 5, 2023 •

Copy link
Copy Markdown
Collaborator

Summary

  • Some of the make targets did not yet work as intended

Checklist

  • Categorize the PR by setting a good title and adding one of the labels:
    bug, enhancement, documentation, change, breaking, dependency
    as they show up in the changelog
  • Update tests.
  • Link this PR to related issues.

@Kidswiss Kidswiss added the bug Something isn't working label Sep 5, 2023
@Kidswiss
Kidswiss requested a review from rxbn September 5, 2023 09:14
@Kidswiss
Kidswiss force-pushed the fix/release branch 2 times, most recently from c35c527 to e8b5530 Compare September 5, 2023 10:54
@Kidswiss
Kidswiss changed the base branch from master to add/bucket September 5, 2023 13:01
@Kidswiss
Kidswiss changed the base branch from add/bucket to master September 5, 2023 13:02
@Kidswiss
Kidswiss requested review from a team, TheBigLee and zugao and removed request for a team and rxbn September 5, 2023 13:04
Comment thread Makefile Resolved

@zugao zugao left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Kidswiss
Kidswiss merged commit 0d641c7 into master Sep 8, 2023
rossigee referenced this pull request in rossigee/provider-minio Jul 24, 2025
Fixes for make targets concerning the release flow
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants